Intermittent dom/base/test/test_intersectionobservers.html | rootBounds should is set to null for cross-origin observations [observe subframe]

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: intermittent-bug-filer, Assigned: tschneider)

Tracking

({intermittent-failure})

unspecified
mozilla55
intermittent-failure
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 fixed, firefox55 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(3 attachments, 3 obsolete attachments)

Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
New test, added in bug 1243846.
Blocks: 1243846
Flags: needinfo?(tschneider)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
See Also: → bug 1313970, bug 1313927
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
No recent failures.
Flags: needinfo?(tschneider)
This is back again now that bug 1321865 has re-landed.
Flags: needinfo?(tschneider)
Back with a vengeance. I would say that this needs to be fixed before we can consider uplifting to Aurora.
(Assignee)

Comment 17

2 years ago
Created attachment 8855186 [details] [diff] [review]
Fix racing condition in intersection observer tests

Fixing intermittent failures due to a racing condition.
Flags: needinfo?(tschneider)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Blocks: 1321865
No longer blocks: 1243846

Comment 18

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d3d0f2d62a
Intermittent dom/base/test/test_intersectionobservers.html | rootBounds should is set to null for cross-origin observations [observe subframe]. r=me
Keywords: checkin-needed
seems that doesn;t fix this - https://treeherder.mozilla.org/logviewer.html#?job_id=89177187&repo=mozilla-inbound after landing of this patch :(
Flags: needinfo?(tschneider)

Comment 20

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45d3d0f2d62a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Bah, leave-open should have been set on this given comment 19.
Assignee: nobody → tschneider
Status: RESOLVED → REOPENED
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
status-firefox54: --- → affected
status-firefox55: fixed → affected
status-firefox-esr52: --- → unaffected
Resolution: FIXED → ---
Target Milestone: mozilla55 → ---
Comment hidden (Intermittent Failures Robot)
See Also: → bug 1324135
with 126 failures in 1 day, I would really like to see this fixed ASAP- In fact this is a new test turned on, so I am going to back this out until we get this looked at.  In bug 1353461 where we turned this on there is no mention of a try push or other data to indicate that this was even tested.

Comment 24

2 years ago
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35af33f46d94
backout bug 1321865 for extremely high test failure rate. r=me
Whiteboard: [stockwell disabled]
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
(Assignee)

Comment 28

2 years ago
I was finally able to reproduce this reliably. The problem was that all our iframe tests load the same iframe content, which calls postMessage on onLoad. Not all of those tests consume the postMessage event tho. That leads to a racing conditions where the test that actually does consume the event receives messages from previous tests.
Flags: needinfo?(tschneider)
(Assignee)

Comment 29

2 years ago
Created attachment 8857572 [details] [diff] [review]
Avoid racing condition by making sure postMessage events are consumed by the correct tests.

Fixes described issue. Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa08a5a24e2a38861ae19dae375d00d9a774a189
Attachment #8855186 - Attachment is obsolete: true
(Assignee)

Comment 31

2 years ago
That will happen if we re-land bug 1321865.
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Comment on attachment 8857572 [details] [diff] [review]
Avoid racing condition by making sure postMessage events are consumed by the correct tests.

LGTM. Thx!
Attachment #8857572 - Flags: review+

Comment 33

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05af3a08fb6f
Avoid racing condition by making sure postMessage events are consumed by the correct tests. r=smaug
Keywords: checkin-needed

Comment 34

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/05af3a08fb6f
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

2 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 35

2 years ago
Created attachment 8858432 [details] [diff] [review]
List intersectionobserver_cross_domain_iframe.html as support file in mochitest.ini

We forgot to list intersectionobserver_cross_domain_iframe.html under the support-files section in mochitest.ini leading to timeout issues when the iframe can't be loaded (not on all platforms tho...).
(Assignee)

Comment 36

2 years ago
Created attachment 8858433 [details] [diff] [review]
List intersectionobserver_cross_domain_iframe.html as support file in mochitest.ini

Should also fix a typo while on it.
Attachment #8858432 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8858433 - Flags: review?(bugs)
Attachment #8858433 - Flags: review?(bugs) → review+
Comment hidden (Intermittent Failures Robot)

Comment 40

2 years ago
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e09a3206a83
List intersectionobserver_cross_domain_iframe.html as support file in mochitest.ini, r=jet
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0e09a3206a83
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
status-firefox54: affected → disabled
(Assignee)

Comment 42

2 years ago
Comment on attachment 8857572 [details] [diff] [review]
Avoid racing condition by making sure postMessage events are consumed by the correct tests.

Approval Request Comment
[Feature/Bug causing the regression]: 1321865
[User impact if declined]: No test coverage
[Is this code covered by automated tests?]: It is one
[Has the fix been verified in Nightly?]: Yes
[Is the change risky?]: No
Attachment #8857572 - Flags: approval-mozilla-beta?
(Assignee)

Comment 43

2 years ago
Comment on attachment 8857572 [details] [diff] [review]
Avoid racing condition by making sure postMessage events are consumed by the correct tests.

not part of the build
Attachment #8857572 - Flags: approval-mozilla-beta?
(Assignee)

Comment 44

2 years ago
Created attachment 8864625 [details] [diff] [review]
Patch for beta uplift
(Assignee)

Updated

2 years ago
Blocks: 1362168
(Assignee)

Updated

2 years ago
Whiteboard: [stockwell disabled] → [stockwell disabled] [checkin-needed-beta]
status-firefox54: disabled → affected

Comment 45

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/c097727dc385
status-firefox54: affected → fixed
Flags: in-testsuite+
Whiteboard: [stockwell disabled] [checkin-needed-beta] → [stockwell fixed]
(Assignee)

Comment 46

2 years ago
Created attachment 8864713 [details] [diff] [review]
Patch for beta uplift

Had an issue when merging back the try-only changes from https://treeherder.mozilla.org/#/jobs?repo=try&revision=95acba62d571c397d08bed74cf963d9f700f9e7e. Should be fixed now.
Attachment #8864625 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.