1313972 - Intermittent dom/base/test/test_intersectionobservers.html | rootBounds should is set to null for cross-origin observations [observe subframe]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=38459908&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/I9hYtQ_xTG-SRIL2zuNA2w/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Intermittent Failures Robot]

15 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 6
* autoland: 6
* mozilla-central: 3

Platform breakdown:
* android-4-3-armv7-api15: 10
* linux64: 4
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-01&endday=2016-11-01&tree=all

Comment 2

[Intermittent Failures Robot]

16 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 10
* mozilla-inbound: 6

Platform breakdown:
* android-4-3-armv7-api15: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-02&endday=2016-11-02&tree=all

Comment 3

[Intermittent Failures Robot]

64 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 29
* autoland: 27
* mozilla-central: 6
* try: 2

Platform breakdown:
* android-4-3-armv7-api15: 57
* linux64: 4
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-10-31&endday=2016-11-06&tree=all

Comment 4

[Geoff Brown [:gbrown]]

New test, added in bug 1243846.

Comment 5

[Intermittent Failures Robot]

16 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 9
* mozilla-inbound: 5
* mozilla-central: 2

Platform breakdown:
* android-4-3-armv7-api15: 15
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-08&endday=2016-11-08&tree=all

Comment 6

[Intermittent Failures Robot]

71 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 30
* autoland: 30
* mozilla-central: 6
* try: 4
* graphics: 1

Platform breakdown:
* android-4-3-armv7-api15: 58
* linux64: 8
* linux32: 3
* windowsxp: 1
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-07&endday=2016-11-13&tree=all

Comment 7

[Intermittent Failures Robot]

19 failures in 113 pushes (0.168 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* autoland: 7
* mozilla-inbound: 6
* mozilla-aurora: 2
* graphics: 2
* try: 1
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api15: 10
* linux64: 7
* windows8-64: 1
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-18&endday=2016-11-18&tree=all

Comment 8

[Intermittent Failures Robot]

74 failures in 715 pushes (0.103 failures/push) were associated with this bug in the last 7 days. 

This is the #33 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* mozilla-inbound: 33
* autoland: 23
* mozilla-aurora: 7
* mozilla-central: 4
* graphics: 4
* try: 3

Platform breakdown:
* android-4-3-armv7-api15: 52
* linux64: 17
* linux32: 2
* windowsxp: 1
* windows8-64: 1
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-14&endday=2016-11-20&tree=all

Comment 9

[Geoff Brown [:gbrown]]

I tried increasing ASYNC_TIMEOUT in https://treeherder.mozilla.org/#/jobs?repo=try&revision=658956b00409dfab83dcf4de9f26959e1c3abb05; it may have eliminated this failure, but it seemed to make bug 1313927 worse (compare to https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6e199567490ef267d6fe595f468eb1c57c8efe5, with no changes).

Comment 10

[Intermittent Failures Robot]

58 failures in 623 pushes (0.093 failures/push) were associated with this bug in the last 7 days. 

This is the #21 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* mozilla-inbound: 22
* autoland: 20
* mozilla-aurora: 10
* mozilla-central: 4
* try: 2

Platform breakdown:
* android-4-3-armv7-api15: 41
* linux64: 13
* windows7-32-vm: 2
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-21&endday=2016-11-27&tree=all

Comment 11

[Intermittent Failures Robot]

17 failures in 110 pushes (0.155 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* autoland: 7
* mozilla-inbound: 6
* mozilla-central: 2
* try: 1
* mozilla-aurora: 1

Platform breakdown:
* android-4-3-armv7-api15: 14
* linux64: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-28&endday=2016-11-28&tree=all

Comment 12

[Intermittent Failures Robot]

25 failures in 694 pushes (0.036 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 14
* mozilla-inbound: 6
* try: 2
* mozilla-central: 2
* mozilla-aurora: 1

Platform breakdown:
* android-4-3-armv7-api15: 19
* linux64: 5
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-11-28&endday=2016-12-04&tree=all

Comment 13

[Intermittent Failures Robot]

6 failures in 305 pushes (0.02 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* try: 2
* mozilla-inbound: 2
* autoland: 2

Platform breakdown:
* linux64: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2016-12-26&endday=2017-01-01&tree=all

Comment 14

[Geoff Brown [:gbrown]]

No recent failures.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

This is back again now that bug 1321865 has re-landed.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Back with a vengeance. I would say that this needs to be fixed before we can consider uplifting to Aurora.

Comment 17

[Tobias Schneider [:tobytailor]]

Attachment: Fix racing condition in intersection observer tests

Fixing intermittent failures due to a racing condition.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d3d0f2d62a
Intermittent dom/base/test/test_intersectionobservers.html | rootBounds should is set to null for cross-origin observations [observe subframe]. r=me

Comment 19

[Carsten Book [:Tomcat]]

seems that doesn;t fix this - https://treeherder.mozilla.org/logviewer.html#?job_id=89177187&repo=mozilla-inbound after landing of this patch :(

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/45d3d0f2d62a

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Bah, leave-open should have been set on this given comment 19.

Comment 22

[Intermittent Failures Robot]

126 failures in 170 pushes (0.741 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 63
* autoland: 32
* try: 13
* mozilla-central: 10
* graphics: 8

Platform breakdown:
* linux64: 60
* linux32: 37
* osx-10-10: 12
* windows7-32-vm: 8
* windows8-64: 7
* windows2012-64: 1
* windows2012-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2017-04-06&endday=2017-04-06&tree=all

Comment 23

[Joel Maher ( :jmaher ) (UTC -8)]

with 126 failures in 1 day, I would really like to see this fixed ASAP- In fact this is a new test turned on, so I am going to back this out until we get this looked at.  In bug 1353461 where we turned this on there is no mention of a try push or other data to indicate that this was even tested.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35af33f46d94
backout bug 1321865 for extremely high test failure rate. r=me

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/35af33f46d94

Comment 26

[Intermittent Failures Robot]

121 failures in 185 pushes (0.654 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 61
* mozilla-inbound: 27
* oak: 11
* graphics: 11
* mozilla-central: 7
* try: 4

Platform breakdown:
* linux64: 47
* linux32: 37
* windows8-64: 19
* windows7-32-vm: 9
* osx-10-10: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2017-04-07&endday=2017-04-07&tree=all

Comment 27

[Intermittent Failures Robot]

311 failures in 867 pushes (0.359 failures/push) were associated with this bug in the last 7 days. 

This is the #4 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 115
* mozilla-inbound: 113
* mozilla-central: 28
* graphics: 22
* try: 21
* oak: 12

Platform breakdown:
* linux64: 137
* linux32: 96
* windows8-64: 31
* osx-10-10: 26
* windows7-32-vm: 19
* windows2012-64: 1
* windows2012-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2017-04-03&endday=2017-04-09&tree=all

Comment 28

[Tobias Schneider [:tobytailor]]

I was finally able to reproduce this reliably. The problem was that all our iframe tests load the same iframe content, which calls postMessage on onLoad. Not all of those tests consume the postMessage event tho. That leads to a racing conditions where the test that actually does consume the event receives messages from previous tests.

Comment 29

[Tobias Schneider [:tobytailor]]

Attachment: Avoid racing condition by making sure postMessage events are consumed by the correct tests.

Fixes described issue. Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa08a5a24e2a38861ae19dae375d00d9a774a189

Comment 30

[Joel Maher ( :jmaher ) (UTC -8)]

please make sure to re-enable this test:
https://dxr.mozilla.org/mozilla-central/source/dom/base/test/mochitest.ini#655

Comment 31

[Tobias Schneider [:tobytailor]]

That will happen if we re-land bug 1321865.

Comment 32

[Jet Villegas (inactive)]

Comment on attachment 8857572 [details] [diff] [review]
Avoid racing condition by making sure postMessage events are consumed by the correct tests.

LGTM. Thx!

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05af3a08fb6f
Avoid racing condition by making sure postMessage events are consumed by the correct tests. r=smaug

Comment 34

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/05af3a08fb6f

Comment 35

[Tobias Schneider [:tobytailor]]

Attachment: List intersectionobserver_cross_domain_iframe.html as support file in mochitest.ini

We forgot to list intersectionobserver_cross_domain_iframe.html under the support-files section in mochitest.ini leading to timeout issues when the iframe can't be loaded (not on all platforms tho...).

Comment 36

[Tobias Schneider [:tobytailor]]

Attachment: List intersectionobserver_cross_domain_iframe.html as support file in mochitest.ini

Should also fix a typo while on it.

Comment 37

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=355bde69a024f29fe5eeb34ed1f91cf0cf2adc01

Comment 38

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=355bde69a024f29fe5eeb34ed1f91cf0cf2adc01

Comment 39

[Intermittent Failures Robot]

22 failures in 894 pushes (0.025 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* graphics: 12
* autoland: 6
* try: 4

Platform breakdown:
* linux64: 11
* linux32: 8
* windows7-32-vm: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313972&startday=2017-04-10&endday=2017-04-16&tree=all

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e09a3206a83
List intersectionobserver_cross_domain_iframe.html as support file in mochitest.ini, r=jet

Comment 41

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0e09a3206a83

Comment 42

[Tobias Schneider [:tobytailor]]

Comment on attachment 8857572 [details] [diff] [review]
Avoid racing condition by making sure postMessage events are consumed by the correct tests.

Approval Request Comment
[Feature/Bug causing the regression]: 1321865
[User impact if declined]: No test coverage
[Is this code covered by automated tests?]: It is one
[Has the fix been verified in Nightly?]: Yes
[Is the change risky?]: No

Comment 43

[Tobias Schneider [:tobytailor]]

Comment on attachment 8857572 [details] [diff] [review]
Avoid racing condition by making sure postMessage events are consumed by the correct tests.

not part of the build

Comment 44

[Tobias Schneider [:tobytailor]]

Attachment: Patch for beta uplift

Comment 45

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c097727dc385

Comment 46

[Tobias Schneider [:tobytailor]]

Attachment: Patch for beta uplift

Had an issue when merging back the try-only changes from https://treeherder.mozilla.org/#/jobs?repo=try&revision=95acba62d571c397d08bed74cf963d9f700f9e7e. Should be fixed now.

Comment 47

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/22f850684d88