1313987 - promiseWarn() rejects incorrectly

Status: RESOLVED INVALID

(DevTools :: Inspector, defect)

Description

[Marcos Caceres [:marcosc]]

Seeing: 
Protocol error (unknownError): can't access dead object utils.js:157

And it looks like there is a typo there:

return promise.reject(error)

Should be:
return Promise.reject(error);

Comment 1

[Marcos Caceres [:marcosc]]

Seeing in the browser toolbox, that is.

Comment 2

[Marcos Caceres [:marcosc]]

Attachment: Fix typo.

Not sure who to assign this to...

Comment 3

[Marcos Caceres [:marcosc]]

The relevant file is devtools/client/inspector/shared/utils.js:157

Comment 4

[Marcos Caceres [:marcosc]]

I'm probably wrong about this one... might just be a closure and an ol' school promise and the error is unrelated.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

We do use `promise` with lowercase "p" in much of the DevTools today, which corresponds to the Promise.jsm toolkit library, as a way to avoid clashing with the native JS promises available as `Promise`.

So, `promiseWarn` itself is probably okay.  It's likely something earlier up the call stack hit a "can't access dead object" error.  :marcosc, what steps are needed to reproduce this?

Comment 6

[Marcos Caceres [:marcosc]]

I saw it coming up in Developer Edition when I filed the bug, but after some attempts I've not been able to reproduce. I'll keep my eye out for it tho and reopen if it happens again.