13140 - [PP]full repaint on link hover (apprunner only)

Status: VERIFIED FIXED

(Core Graveyard :: GFX, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  I built with --disable-double-buffer.  I can see that mousing over
links in apprunner, even if there is no need to repaint because of a style
change, causes a full repaint of the document frame.  This does not happen in
viewer or in an iframe within viewer.

This may be platform-specific.

STEPS TO REPRODUCE:
 * build with --disable-double-buffer
 * load attached test case in apprunner
 * move mouse on or off the word "link"

ACTUAL RESULTS:
 * The entire document repaints - there is a white flash covering the whole
document frame.

EXPECTED RESULTS:
 * no repaint, since there's no style change

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-08-28, build at 12:15 PDT.

WORKS CORRECTLY ON:
 * Linux, viewer, 1999-08-28, build at 12:15 PDT.

ADDITIONAL INFORMATION:
Fixing this would greatly improve the performance of link hovers on Linux.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test case described in bug

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: page with iframe containing above testcase

Comment 3

[don]

Patrick, is this one for you?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The new (debug-build only) pref option "Edit|Preferences|Debug|Flash
Invalidate() Areas" makes this *much* easier to see (I don't know if it works
yet anywhere other than Linux).  It also makes it quite painful to watch. :-(
It also shows that not only the entire document window, but also the URL bar and
most of one of the bottom toolbars are also being repainted.

Comment 5

[Patrick C. Beard]

Doesn't happen on the Mac. I believe this is Linux-specific.

Comment 6

[leger]

Puttin on [PP] radar.

Comment 7

[chris hofmann]

dp, is this the bug you are looking at today????

Comment 8

[chris hofmann]

dp, is this the bug you are looking at today????

Comment 9

[chris hofmann]

dp, is this the bug you are looking at today????

Comment 10

[Suresh Duddi (gone)]

Yes. I enabled flash paint area in Pref->Debug and i see the entire browser
being repainted whenever I move my mouse into a link or out of a link. If we
are in a frames page, the frames paint individually and the entire page paints
one more time.

This sucks big time. I see this on unix only.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 14817 has been marked as a duplicate of this bug. ***

Comment 12

[ramiro]

pavlov just checked in a fix for this.

reassigning to pavlov to close the bug.

thanks pav.

Comment 13

[Stuart Parmenter]

fixed fixed fixed!

Comment 14

[leger]

Putting on [PDT+] radar.

Comment 15

[leger]

petersen, can you please verify that this is fixed with todays M11 branch build.
 Thanks!

Comment 16

[Chris Petersen]

Yes, this problem is fixed in the M11 Nov 11th build.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a173d675e98
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13140: Use concept-menu for saved logins menu (https://github.com/mozilla-mobile/fenix/pull/13143)