1314001 - Implement pref:layers.paintMask

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

A preference helps css-mask debugging.
1. Default value of layers.paintMask is false.
2. When layers.paintMask is set, paint mask surface as color surface and discard  masked content rendering, then we can see the shape and position of mask on screen.

Comment 1

[u459114]

Attachment: Bug 1314001 - Part 1. Add pref: layers.draw-mask-debug.

Review commit: https://reviewboard.mozilla.org/r/90564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90564/

Comment 2

[u459114]

Attachment: Bug 1314001 - Part 2. Draw mask by single opaque green.

Review commit: https://reviewboard.mozilla.org/r/90566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90566/

Comment 3

[u459114]

Attachment: before-after-enable-pref.png

Comment 4

[u459114]

While developing mask, 
1. masked content look weird. It might be caused by generate wrong mask surface. I need to set break point in gdb and call gfxContext::WriteAsPNG to dump mask surface to know how mask look like.
2. Use report a bug said something wrong with mask. I need a quicker way to find out where is the mask visually.
There are reasons for constructing this preference.

Comment 5

[u459114]

Comment on attachment 8807423 [details]
Bug 1314001 - Part 2. Draw mask by single opaque green.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90566/diff/1-2/

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8807422 [details]
Bug 1314001 - Part 1. Add pref: layers.draw-mask-debug.

https://reviewboard.mozilla.org/r/90564/#review90508

::: gfx/thebes/gfxPrefs.h:525
(Diff revision 1)
>    DECL_GFX_PREF(Live, "layers.tiles.fade-in.enabled",          LayerTileFadeInEnabled, bool, false);
>    DECL_GFX_PREF(Live, "layers.tiles.fade-in.duration-ms",      LayerTileFadeInDuration, uint32_t, 250);
>    DECL_GFX_PREF(Live, "layers.transaction.warning-ms",         LayerTransactionWarning, uint32_t, 200);
>    DECL_GFX_PREF(Once, "layers.uniformity-info",                UniformityInfo, bool, false);
>    DECL_GFX_PREF(Once, "layers.use-image-offscreen-surfaces",   UseImageOffscreenSurfaces, bool, true);
> +  DECL_GFX_PREF(Live, "layers.draw-mask-layer",          DrawMaskLayer, bool, false);

I think the name should have "debug" somewhere in its name. How about:

layers.mask-debug-overlay
layers.draw-mask-debug
nglayout.debug.mask_fill

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8807423 [details]
Bug 1314001 - Part 2. Draw mask by single opaque green.

https://reviewboard.mozilla.org/r/90566/#review90510

Comment 8

[u459114]

Comment on attachment 8807422 [details]
Bug 1314001 - Part 1. Add pref: layers.draw-mask-debug.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90564/diff/1-2/

Comment 9

[u459114]

Comment on attachment 8807423 [details]
Bug 1314001 - Part 2. Draw mask by single opaque green.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90566/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db9d20ea9e05
Part 1. Add pref: layers.draw-mask-debug. r=mstange
https://hg.mozilla.org/integration/autoland/rev/19fabb7bf063
Part 2. Draw mask by single opaque green. r=mstange

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/db9d20ea9e05
https://hg.mozilla.org/mozilla-central/rev/19fabb7bf063

Comment 12

[u459114]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a9a6e524a7b21fec801bda1679fb06e721628b6
Bug 1314001 - (followup) give different color to different kind of mask. r=me

Comment 13

[Phil Ringnalda (:philor)]

Backed that followup out in https://hg.mozilla.org/integration/mozilla-inbound/rev/376b3896239c for Windows bustage, https://treeherder.mozilla.org/logviewer.html#?job_id=41132441&repo=mozilla-inbound

Comment 14

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=640cd4b65544

Comment 15

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5299eeacc35e

Comment 16

[u459114]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2b309cad8cab5a02175e9be55da7ddae905ac3d
Bug 1314001 - (followup) give different color to different kind of mask. r=me

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c2b309cad8ca