1314021 - move conditions to their own table

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

As part of the review for conditional scheduled changes, Johan came up with the idea of moving conditions to their own table. This cleans up the schema a bit by keeping the primary scheduled changes table focused on the future version of the thing, and putting the scheduling information elsewhere.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: move conditions to their own table

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8805929 [details] [review]
move conditions to their own table

Looks good to me! More details in the PR.

Comment 3

[[e-mail] (:bhearsum)]

I did a bad thing with the upgrade script for this - I made it incompatible with the old code. When we upgraded stage, we started getting tracebacks like https://sentry.prod.mozaws.net/operations/stage-admin/issues/366228/.

Everything was fine once the new code was deployed, and since it's admin only, I'm not going to back out for this. In the future I need to be better at making sure any given upgrade script works with both the old and the new code, though.

In the time between upgrading the prod db and upgrading the admin node to the new code, we will see these exceptions whenever the Balrog Agent makes a request, too.

Comment 4

[[e-mail] (:bhearsum)]

In production. Thanks to Johan for this good idea!