Closed Bug 1314023 Opened 3 years ago Closed 3 years ago

Trunk as aurora simulations busted some builds due to duplicated files are not allowed

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(firefox52+ fixed)

RESOLVED FIXED
Tracking Status
firefox52 + fixed

People

(Reporter: cbook, Unassigned)

References

()

Details

Attachments

(1 file)

Running trunk as aurora simulations [1] resulted in a lot of build failures like

 09:49:46     INFO -    browser/chrome/devtools/content/framework/dev-edition-promo/dev-edition-logo.png
 09:49:46     INFO -  WARNING: Found 35 duplicated files taking 79019 bytes (58573 compressed)
 09:49:46     INFO -  ERROR: The following duplicated files are not allowed:
 09:49:46     INFO -  browser/chrome/browser/content/browser/defaultthemes/devedition.icon.png
 09:49:46     INFO -  browser/chrome/browser/content/branding/icon64.png
09:49:46 INFO - browser/chrome/devtools/content/framework/dev-edition-promo/dev-edition-logo.png 

https://treeherder.mozilla.org/logviewer.html#?job_id=30102250&repo=try


[1]https://treeherder.mozilla.org/#/jobs?repo=try&revision=38dd425178cb9048e62cfed7e1461aac310dd19c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Blocks: 1303184
[Tracking Requested - why for this release]:

if we don't fix this i guess most builds (all but not linux32 opt) would be broken on merge day from trunk to aurora
Tracking 52+ for the very compelling reason in Comment 1.
catlee can we fix this till merge day (monday i guess)
Flags: needinfo?(catlee)
I have a patch here that I think fixes the issue:
https://diff.pastebin.mozilla.org/8924463
Flags: needinfo?(catlee)
(In reply to Chris AtLee [:catlee] from comment #4)
> I have a patch here that I think fixes the issue:
> https://diff.pastebin.mozilla.org/8924463

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac821b84724024c56e3c9420c7978853c07b0fe3 is the try run with this changes
(In reply to Chris AtLee [:catlee] from comment #8)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b5fa6f70292

last try run went great and so let ship it :)
Flags: needinfo?(catlee)
Attachment #8808609 - Flags: review?(cbook)
Comment on attachment 8808609 [details]
Bug 1314023 - Add dev edition branding exceptions to allowed duplicates

https://reviewboard.mozilla.org/r/91408/#review91272
Attachment #8808609 - Flags: review?(cbook) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53049dd09053
Add dev edition branding exceptions to allowed duplicates r=Tomcat
Flags: needinfo?(catlee)
https://hg.mozilla.org/mozilla-central/rev/53049dd09053
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.