Trunk as aurora simulations busted some builds due to duplicated files are not allowed

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: Tomcat, Unassigned)

Tracking

unspecified

Firefox Tracking Flags

(firefox52+ fixed)

Details

(URL)

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Running trunk as aurora simulations [1] resulted in a lot of build failures like

 09:49:46     INFO -    browser/chrome/devtools/content/framework/dev-edition-promo/dev-edition-logo.png
 09:49:46     INFO -  WARNING: Found 35 duplicated files taking 79019 bytes (58573 compressed)
 09:49:46     INFO -  ERROR: The following duplicated files are not allowed:
 09:49:46     INFO -  browser/chrome/browser/content/browser/defaultthemes/devedition.icon.png
 09:49:46     INFO -  browser/chrome/browser/content/branding/icon64.png
09:49:46 INFO - browser/chrome/devtools/content/framework/dev-edition-promo/dev-edition-logo.png 

https://treeherder.mozilla.org/logviewer.html#?job_id=30102250&repo=try


[1]https://treeherder.mozilla.org/#/jobs?repo=try&revision=38dd425178cb9048e62cfed7e1461aac310dd19c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Updated

2 years ago
Blocks: 1303184
(Reporter)

Comment 1

2 years ago
[Tracking Requested - why for this release]:

if we don't fix this i guess most builds (all but not linux32 opt) would be broken on merge day from trunk to aurora
tracking-firefox52: --- → ?
Tracking 52+ for the very compelling reason in Comment 1.
tracking-firefox52: ? → +
(Reporter)

Comment 3

2 years ago
catlee can we fix this till merge day (monday i guess)
Flags: needinfo?(catlee)
I have a patch here that I think fixes the issue:
https://diff.pastebin.mozilla.org/8924463
Flags: needinfo?(catlee)
(Reporter)

Comment 5

2 years ago
(In reply to Chris AtLee [:catlee] from comment #4)
> I have a patch here that I think fixes the issue:
> https://diff.pastebin.mozilla.org/8924463

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac821b84724024c56e3c9420c7978853c07b0fe3 is the try run with this changes
(Reporter)

Comment 9

2 years ago
(In reply to Chris AtLee [:catlee] from comment #8)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b5fa6f70292

last try run went great and so let ship it :)
Flags: needinfo?(catlee)
Comment hidden (mozreview-request)

Updated

2 years ago
Attachment #8808609 - Flags: review?(cbook)
(Reporter)

Comment 11

2 years ago
mozreview-review
Comment on attachment 8808609 [details]
Bug 1314023 - Add dev edition branding exceptions to allowed duplicates

https://reviewboard.mozilla.org/r/91408/#review91272
Attachment #8808609 - Flags: review?(cbook) → review+

Comment 12

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53049dd09053
Add dev edition branding exceptions to allowed duplicates r=Tomcat

Updated

2 years ago
Flags: needinfo?(catlee)
(Reporter)

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/53049dd09053
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
(Assignee)

Updated

2 months ago
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.