1314028 - Intermittent dom/promise/tests/test_webassembly_compile.html | application crashed [@ JSContext::getPendingException(JS::MutableHandle<JS::Value>)]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Treeherder Bug Filer]

Filed by: tomcat [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=38455381&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1477850721/mozilla-inbound_win7_vm-debug_test-mochitest-3-bm138-tests1-windows-build145.txt.gz

Comment 1

[Luke Wagner [:luke]]

Fortunately, it looks like the crashing condition is pretty simple: GetAndClearException() is being called when no exception is pending.  This seems to be called by AbruptRejectPromise which was just added in bug 1313049.  So what this test is doing is calling worker.terminate() when that worker has a bunch of pending promises.  I believe terminate() uses the interrupt callback to abruptly terminate, so I expect that is why, even though JS::ForOfIterator::init() is returning false, no exception is pending.  So I expect the fix is to handle the !cx->isExceptionPending() case.

Comment 2

[Till Schneidereit [:till]]

Attachment: Bug 1314028 - Don't try to handle uncatchable exceptions in AbruptRejectPromise.

Review commit: https://reviewboard.mozilla.org/r/90526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90526/

Comment 3

[Till Schneidereit [:till]]

(In reply to Luke Wagner [:luke] from comment #1)
> So I expect the fix is to handle the !cx->isExceptionPending()
> case.

Yeah, except I'm not sure how much handling there is to do, really. I *think* just bailing is the best we can do in this situation, so the patch I just asked for review for does that.

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 8807349 [details]
Bug 1314028 - Don't try to handle uncatchable exceptions in AbruptRejectPromise.

https://reviewboard.mozilla.org/r/90526/#review90250

Makes sense.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c71bdc18c5c7
Don't try to handle uncatchable exceptions in AbruptRejectPromise. r=luke

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c71bdc18c5c7

Comment 7

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* autoland: 2
* mozilla-central: 1

Platform breakdown:
* windows8-64: 3
* windowsxp: 1
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314028&startday=2016-10-31&endday=2016-11-06&tree=all