1314101 - testing/marionette/test_action.js is failing

Status: RESOLVED WORKSFORME

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

I discovered by chance that testing/marionette/test_action.js is not being run on try.  I don’t know yet why that is the case and should probably file a separate bug for that.

However, running the testing/marionette/test_action.js xpcshell test gives the following failures after fixing the testing/marionette/error.js import is added:

% ./mach xpcshell-test --sequential  testing/marionette/test_action.js
Elapsed: 1.03s; From _tests: Kept 29877 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.23 LOG: MainThread INFO Running tests sequentially.
 0:00.24 SUITE_START: MainThread 1
 0:00.24 LOG: Thread-1 INFO profile dir is /tmp/firefox/xpcshellprofile
 0:00.24 TEST_START: Thread-1 testing/marionette/test_action.js
 0:00.24 LOG: Thread-1 INFO testing/marionette/test_action.js | full command: ['/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin/xpcshell', '-g', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin', '-a', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin', '-r', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin/components/httpd.manifest', '-m', '-s', '-e', 'const _HEAD_JS_PATH = "/home/ato/src/gecko/testing/xpcshell/head.js";', '-e', 'const _MOZINFO_JS_PATH = "/tmp/firefox/xpcshellprofile/mozinfo.json";', '-e', 'const _TESTING_MODULES_DIR = "/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_tests/modules/";', '-f', '/home/ato/src/gecko/testing/xpcshell/head.js', '-p', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/temp/xpc-plugins-k_5NWZ', '-e', 'const _SERVER_ADDR = "localhost"', '-e', 'const _HEAD_FILES = [];', '-e', 'const _TAIL_FILES = [];', '-e', 'const _JSDEBUGGER_PORT = 0;', '-e', 'const _TEST_FILE = ["/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_tests/xpcshell/testing/marionette/test_action.js"];', '-e', 'const _TEST_NAME = "testing/marionette/test_action.js"', '-e', '_execute_test(); quit(0);']
 0:00.24 LOG: Thread-1 INFO testing/marionette/test_action.js | current directory: '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_tests/xpcshell/testing/marionette'
 0:00.24 LOG: Thread-1 INFO testing/marionette/test_action.js | environment: ['XPCOM_DEBUG_BREAK=stack-and-abort', 'MOZ_CRASHREPORTER=1', 'XPCSHELL_TEST_TEMP_DIR=/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/temp/xpc-other-mggvTY', 'LD_LIBRARY_PATH=/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin', 'MOZ_DISABLE_NONLOCAL_CONNECTIONS=1', 'XPCSHELL_TEST_PROFILE_DIR=/tmp/firefox/xpcshellprofile', 'MOZ_CRASHREPORTER_NO_REPORT=1']
 0:00.26 PROCESS_OUTPUT: Thread-1 (pid:2416) Full command: ['/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin/xpcshell', '-g', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin', '-a', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin', '-r', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/bin/components/httpd.manifest', '-m', '-s', '-e', 'const _HEAD_JS_PATH = "/home/ato/src/gecko/testing/xpcshell/head.js";', '-e', 'const _MOZINFO_JS_PATH = "/tmp/firefox/xpcshellprofile/mozinfo.json";', '-e', 'const _TESTING_MODULES_DIR = "/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_tests/modules/";', '-f', '/home/ato/src/gecko/testing/xpcshell/head.js', '-p', '/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/temp/xpc-plugins-k_5NWZ', '-e', 'const _SERVER_ADDR = "localhost"', '-e', 'const _HEAD_FILES = [];', '-e', 'const _TAIL_FILES = [];', '-e', 'const _JSDEBUGGER_PORT = 0;', '-e', 'const _TEST_FILE = ["/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_tests/xpcshell/testing/marionette/test_action.js"];', '-e', 'const _TEST_NAME = "testing/marionette/test_action.js"', '-e', '_execute_test(); quit(0);']
(pid:2416) "** (xpcshell:2416): WARNING **: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-S3FmgBeWA5: Connection refused"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 39: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 45: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 45: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 51: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 71: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 89: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 89: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 98: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 101: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 101: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 114: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 124: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 139: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 139: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 139: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 157: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 169: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 171: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.32 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: chrome://marionette/content/atom.js, line 172: SyntaxError: test for equality (==) mistyped as assignment (=)?"
 0:00.33 LOG: Thread-1 INFO (xpcshell/head.js) | test MAIN run_test pending (1)
 0:00.33 LOG: Thread-1 INFO (xpcshell/head.js) | test run_next_test 0 pending (2)
 0:00.33 LOG: Thread-1 INFO (xpcshell/head.js) | test MAIN run_test finished (2)
 0:00.33 LOG: Thread-1 INFO running event loop
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 39 column: 1250 source: "=K.prototype;p.p=k;p.q=0;p.ha=l;function L(a,b,c,d){if(a.p=b)a.q="number"==typeof c?c:1!=a.p.nodeType?0:a.o?-1:1;"number"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 45 column: 425 source: "b[b]||b,d=a[c];if(!r(d)&&0<=A(Ab,c))return l;if(c="value"==b)if(c=M(a,"OPTION")){var e;c=b.toLowerCase();if(a.hasAttribu"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 45 column: 444 source: "r(d)&&0<=A(Ab,c))return l;if(c="value"==b)if(c=M(a,"OPTION")){var e;c=b.toLowerCase();if(a.hasAttribute)e=a.hasAttribute"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 51 column: 145 source: "usemap = "#'+a.name+'"]',f):gb(f,function(b){var c;if(c=M(b))8==b.nodeType?b=k:(c="usemap","style"==c?(b=ha(b.style.cssT"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 71 column: 68 source: "tion(a,b){var c=F(D(this.b()));if(c=(c=Cc(c||window))&&Jc(c))var d=c.b(),e=c.g(),f=c.j(),j=c.k();var m=this.a.cloneRange"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 89 column: 86 source: "=c)return d<b;var e;if(1==a.nodeType&&b)if(e=a.childNodes[b])a=e,b=0;else if(G(a,c))return i;if(1==c.nodeType&&d)if(e=c."}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 89 column: 159 source: " if(G(a,c))return i;if(1==c.nodeType&&d)if(e=c.childNodes[d])c=e,d=0;else if(G(c,a))return l;return 0<(cb(a,c)||b-d)};fu"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 98 column: 985 source: "f;L.prototype.c=0;L.prototype.d=g;function M(a,c,b){if(a.b=c)a.c="number"==typeof b?b:1!=a.b.nodeType?0:a.a?-1:1}
"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 101 column: 86 source: "||c,d=a[b];if(void 0===d&&0<=u(R,b))return g;if(b="value"==c)if(b=O(a,"OPTION")){var e;b=c.toLowerCase();if(a.hasAttribu"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 101 column: 105 source: "0===d&&0<=u(R,b))return g;if(b="value"==c)if(b=O(a,"OPTION")){var e;b=c.toLowerCase();if(a.hasAttribute)e=a.hasAttribute"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 114 column: 730 source: "i;Q.prototype.c=0;Q.prototype.e=j;function R(a,b,c){if(a.b=b)a.c="number"==typeof c?c:1!=a.b.nodeType?0:a.a?-1:1}
"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 124 column: 142 source: "usemap = "#'+a.name+'"]',f):la(f,function(b){var c;if(c=U(b))8==b.nodeType?b=i:(c="usemap","style"==c?(b=p(b.style.cssTe"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 139 column: 1492 source: "o"==c)b="checked";var c=b,d=J[c]||c,b=a[d],e;if(e=void 0===b){b:if("string"==typeof K)d="string"!=typeof d||1!=d.length?"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 139 column: 1672 source: "]===d){d=e;break b}d=-1}e=0<=d}if(e)a=f;else{if(d="value"==c)if(d=H(a,"OPTION")){var j;c=c.toLowerCase();if(a.hasAttribu"}]"
 0:00.33 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 139 column: 1691 source: "d=-1}e=0<=d}if(e)a=f;else{if(d="value"==c)if(d=H(a,"OPTION")){var j;c=c.toLowerCase();if(a.hasAttribute)j=a.hasAttribute"}]"
 0:00.34 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 157 column: 491 source: "!=a.nodeType&&(b+=a.nodeValue),d[c++]=a;while(a=a.firstChild);for(;c&&!(a=d[--c].nextSibling););}}else b=a.nodeValue;ret"}]"
 0:00.34 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 169 column: 884 source: "new K,d=b;do a.matches(d)&&c.unshift(d);while(d=d.parentNode);return c},!0);
"}]"
 0:00.34 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 171 column: 144 source: "&&a.matches(f)&&e.add(f),e=J(a,f,c,d,e);while(b=b.parentNode);return e},!1,!0);P("following-sibling",function(a,b){for(v"}]"
 0:00.34 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://marionette/content/atom.js" line: 172 column: 85 source: "b,c,d){var e=new K,f=[];do f.unshift(b);while(b=b.parentNode);for(var g=1,w=f.length;g<w;g++){var p=[];for(b=f[g];b=b.pr"}]"
 0:00.34 LOG: Thread-1 INFO testing/marionette/test_action.js | Starting test_createAction
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test test_createAction pending (2)
 0:00.34 TEST_STATUS: Thread-1 test_createAction PASS [test_createAction : 14] . Missing Action constructor args
 0:00.34 TEST_STATUS: Thread-1 test_createAction PASS [test_createAction : 16] . Missing Action constructor args
 0:00.34 TEST_STATUS: Thread-1 test_createAction PASS [test_createAction : 18] . Non-string arguments.
 0:00.34 TEST_STATUS: Thread-1 test_createAction PASS [test_createAction : 20] {"id":"id","type":"sometype","subtype":"sometype"} == true
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test run_next_test 1 pending (3)
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test test_createAction finished (3)
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test run_next_test 0 finished (2)
 0:00.34 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
 0:00.34 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
 0:00.34 LOG: Thread-1 INFO testing/marionette/test_action.js | Starting test_defaultPointerParameters
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test test_defaultPointerParameters pending (2)
 0:00.34 TEST_STATUS: Thread-1 test_defaultPointerParameters PASS [test_defaultPointerParameters : 27] {"pointerType":"mouse","primary":true} deepEqual {"pointerType":"mouse","primary":true}
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test run_next_test 2 pending (3)
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test test_defaultPointerParameters finished (3)
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test run_next_test 1 finished (2)
 0:00.34 LOG: Thread-1 INFO testing/marionette/test_action.js | Starting test_processPointerParameters
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test test_processPointerParameters pending (2)
 0:00.34 PROCESS_OUTPUT: Thread-1 (pid:2416) "JavaScript strict warning: /home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_tests/xpcshell/testing/marionette/test_action.js, line 37: ReferenceError: reference to undefined property parametersData.primary"
 0:00.34 TEST_STATUS: Thread-1 test_processPointerParameters PASS [test_processPointerParameters : 477] . parametersData: [pointerType: foo, primary: undefined]
 0:00.34 TEST_STATUS: Thread-1 test_processPointerParameters PASS [test_processPointerParameters : 478] . parametersData: [pointerType: foo, primary: undefined]
 0:00.34 TEST_STATUS: Thread-1 test_processPointerParameters PASS [test_processPointerParameters : 477] . parametersData: [pointerType: foo, primary: undefined]
 0:00.34 LOG: Thread-1 ERROR InvalidArgumentError: Expected primary to be boolean, got a
/home/ato/src/gecko/testing/xpcshell/head.js:_run_next_test:1583
/home/ato/src/gecko/testing/xpcshell/head.js:do_execute_soon/<.run:713
/home/ato/src/gecko/testing/xpcshell/head.js:_do_main:210
/home/ato/src/gecko/testing/xpcshell/head.js:_execute_test:545
-e:null:1
 0:00.34 LOG: Thread-1 INFO exiting test
 0:00.34 LOG: Thread-1 INFO (xpcshell/head.js) | test run_next_test 2 finished (2)
 0:00.34 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property parametersData.primary" {file: "/home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_tests/xpcshell/testing/marionette/test_action.js" line: 37}]"
 0:00.36 TEST_END: Thread-1 Harness FAIL, expected PASS. Subtests passed 8/8. Unexpected 1
xpcshell return code: 0
 0:00.36 LOG: MainThread INFO INFO | Result summary:
 0:00.36 LOG: MainThread INFO INFO | Passed: 0
 0:00.36 LOG: MainThread INFO INFO | Failed: 1
 0:00.36 LOG: MainThread INFO INFO | Todo: 0
 0:00.36 LOG: MainThread INFO INFO | Retried: 0
 0:00.36 SUITE_END: MainThread 
Summary
=======

Ran 9 tests (1 parents, 8 subtests)
Expected results: 8
Unexpected results: 1 (FAIL: 1)

Unexpected Results
==================

testing/marionette/test_action.js
---------------------------------
FAIL [Parent]

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I can't reproduce these failures locally on latest m-c after a clobber. All tests pass. I didn't have to fix any imports either. Can you try again and confirm?

Re try: I couldn't find test_action.js in try today, which is odd, because my push from Oct 28th (via MozReview) does include test_action.js: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=30107325

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Hmmm, I do see test_action.js in other try pushes today as well: https://treeherder.mozilla.org/#/jobs?repo=try&filter-searchStr=xpcshell&fromchange=d8d1f3b80ddad849343ab9018af7c873c421a159&selectedJob=30243164

Comment 3

[Andreas Tolfsen ❲:ato❳]

I’m not able to reproduce this.  I guess I must have had a locally edited file checked out.  Odd.