Closed Bug 1314161 Opened 7 years ago Closed 7 years ago

Stylo panics while restyling a comment node trying to convert it to an element.

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Patch.
9.38 KB, patch
bholley
: review+
Details | Diff | Splinter Review 
Manishearth and I hit this today.
Attached patch Patch. — — Splinter Review 
This is very in flux with your recent changes Bobby, so not sure if you want to check this in or you have already a different approach.

Also, probably StyleChildrenIterator should skip over irrelevant nodes, I guess, though I didn't have the time to write that right now.
Attachment #8806156 - Flags: review?(bobbyholley)
Comment on attachment 8806156 [details] [diff] [review]
Patch.

Review of attachment 8806156 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this.
Attachment #8806156 - Flags: review?(bobbyholley) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c49ec67995bc
stylo: Don't try to recreate style contexts for non-element and non-text nodes. r=bholley
https://hg.mozilla.org/mozilla-central/rev/c49ec67995bc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.