1314179 - `PlacesSyncUtils.bookmarks.remove` passes the wrong source to observers

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Lina Butler [:lina]]

I had one job. :-)

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1314179 - Ensure `PlacesSyncUtils.bookmarks.remove` passes the correct source to observers.

Review commit: https://reviewboard.mozilla.org/r/89676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89676/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8806180 [details]
Bug 1314179 - Ensure `PlacesSyncUtils.bookmarks.remove` passes the correct source to observers.

https://reviewboard.mozilla.org/r/89676/#review89414

Comment 3

[Lina Butler [:lina]]

Comment on attachment 8806180 [details]
Bug 1314179 - Ensure `PlacesSyncUtils.bookmarks.remove` passes the correct source to observers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89676/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dffbcbe37c9
Ensure `PlacesSyncUtils.bookmarks.remove` passes the correct source to observers. r=markh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8dffbcbe37c9

Comment 6

[Lina Butler [:lina]]

Comment on attachment 8806180 [details]
Bug 1314179 - Ensure `PlacesSyncUtils.bookmarks.remove` passes the correct source to observers.

Approval Request Comment
[Feature/regressing bug #]: Bug 1299338.
[User impact if declined]: Unnecessary syncs when applying bookmark deletions from another device.
[Describe test coverage new/current, TreeHerder]: Covered by existing tests and TPS.
[Risks and why]: Low risk; small change to the `remove` method and a test fix.
[String/UUID change made/needed]: None.

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8806180 [details]
Bug 1314179 - Ensure `PlacesSyncUtils.bookmarks.remove` passes the correct source to observers.

Fix an issue related to sync. Take it in 51 aurora.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/64a63ba0f3ef