Closed Bug 1314189 Opened 3 years ago Closed 3 years ago

Only create a RemoteVideoDecoder if the current LayerManager is using the GPU process

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8806190 - Flags: review?(dvander)
Comment on attachment 8806190 [details] [diff] [review]
right-knows-compositor-type

Review of attachment 8806190 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GfxMessageUtils.h
@@ +900,5 @@
>  
>    static bool Read(const Message* aMsg, PickleIterator* aIter, paramType* aResult)
>    {
>      bool result = ReadParam(aMsg, aIter, &aResult->mParentBackend) &&
> +                  ReadParam(aMsg, aIter, &aResult->mParentProcessId) &&

Pre-existing, but this really should have been called "mParentProcessType".
Attachment #8806190 - Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/070a68ae4962
Only create a RemoteVideoDecoder if the current LayerManager is using the GPU process. r=dvander
https://hg.mozilla.org/mozilla-central/rev/070a68ae4962
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.