1314212 - re-enable all-webm tests

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

test_WaitingOnMissingData.html should be re-enabled.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1314212: P1. Update and re-enable MSE mochitest.

Review commit: https://reviewboard.mozilla.org/r/89730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89730/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8806244 [details]
Bug 1314212: P1. Update and re-enable MSE mochitest.

https://reviewboard.mozilla.org/r/89730/#review89208

::: dom/media/mediasource/test/test_WaitingOnMissingData.html:26
(Diff revision 1)
> -      loadSegment.bind(null, new Uint8Array(arrayBuffer, 318, 25223-318))).then(
> -      loadSegment.bind(null, new Uint8Array(arrayBuffer, 25223, 46712-25223))).then(
> +      .then(loadSegment.bind(null, sb, new Uint8Array(arrayBuffer, 318, 25223-318)))
> +      .then(loadSegment.bind(null, sb, new Uint8Array(arrayBuffer, 25223, 46712-25223)))
>        /* Note - Missing |46712, 67833 - 46712| segment here */
> -      loadSegment.bind(null, new Uint8Array(arrayBuffer, 67833, 88966 - 67833))).then(
> -      loadSegment.bind(null, new Uint8Array(arrayBuffer, 88966))).then(function() {
> -
> +      .then(loadSegment.bind(null, sb, new Uint8Array(arrayBuffer, 67833, 88966 - 67833)))
> +      .then(loadSegment.bind(null, sb, new Uint8Array(arrayBuffer, 88966)))
> +	    .then(function() {

Replace tab characters with spaces (you may want to check your editor settings about that).

::: dom/media/mediasource/test/test_WaitingOnMissingData.html:51
(Diff revision 1)
> +	      // These fuzz factors are bigger than they should be. We should investigate
> +	      // and fix them in bug 1137574.

Bug 1137574 is resolved as "works for me", so either this comment is wrong, or the fuzz needs readjusting.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8806244 [details]
Bug 1314212: P1. Update and re-enable MSE mochitest.

https://reviewboard.mozilla.org/r/89730/#review89208

> Bug 1137574 is resolved as "works for me", so either this comment is wrong, or the fuzz needs readjusting.

I've re-opened that bug

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8806244 [details]
Bug 1314212: P1. Update and re-enable MSE mochitest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89730/diff/1-2/

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1314212: P2. Update and re-enable MSE mochitest.

Review commit: https://reviewboard.mozilla.org/r/90010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90010/

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8806244 [details]
Bug 1314212: P1. Update and re-enable MSE mochitest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89730/diff/2-3/

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8806608 [details]
Bug 1314212: P2. Update and re-enable MSE mochitest.

https://reviewboard.mozilla.org/r/90010/#review89532

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e7430fec989
P1. Update and re-enable MSE mochitest. r=gerald
https://hg.mozilla.org/integration/autoland/rev/086788927d4e
P2. Update and re-enable MSE mochitest. r=gerald

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3e7430fec989
https://hg.mozilla.org/mozilla-central/rev/086788927d4e