Closed Bug 1314251 Opened 3 years ago Closed 3 years ago

E10S: Alt+UpArrow to close a combobox and accept the current selection does not work in E10S mode, works with E10S off

Categories

(Core :: Widget: Win32, defect, P3)

52 Branch
x86
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: MarcoZ, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: tpi:+)

Attachments

(1 file)

Found by Jamie Teh and mentioned in Bug 1309271 Comment #5:

>There's another bug here too, but this probably isn't a11y specific. With e10s enabled, you can no longer press alt+upArrow to collapse a combo box. You must press escape or enter. This works as expected with e10s disabled.

So the steps are:
1. Find a <select size="1"> combobox with some entries.
2. Press Alt+Down Arrow to expand. This works as expected.
3. Press Alt+UpArrow to collapse.

Expected: Combobox should collapse, and current selection should be reflected in the collapsed combobox.
Actual: Does not work.

4. Do the same with E10S disabled.

Result: Both keystrokes work as expected.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #8808994 - Flags: review?(ksteuber)
Attachment #8808994 - Flags: review?(ksteuber) → review+
Blocks: e10s-select
Priority: -- → P3
Whiteboard: tpi:+
Flags: needinfo?(enndeakin)
https://hg.mozilla.org/mozilla-central/rev/7aba2499cb40
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Neil, is that something that we want to uplift to 52? Thanks
Flags: needinfo?(enndeakin)
Keywords: regression
Comment on attachment 8808994 [details] [diff] [review]
Close popup on alt+up/down

Approval Request Comment
[Feature/Bug causing the regression]: e10s only
[User impact if declined]: inconsistent dropdown closing behaviour on e10s/non-e10s
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no, minor change
[Why is the change risky/not risky?]: no
[String changes made/needed]: no
Flags: needinfo?(enndeakin)
Attachment #8808994 - Flags: approval-mozilla-beta?
Comment on attachment 8808994 [details] [diff] [review]
Close popup on alt+up/down

close popup on alt+up, e10s regression fix for beta52
Attachment #8808994 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.