1314251 - E10S: Alt+UpArrow to close a combobox and accept the current selection does not work in E10S mode, works with E10S off

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P3)

Description

[Marco Zehe (:MarcoZ)]

Found by Jamie Teh and mentioned in Bug 1309271 Comment #5:

>There's another bug here too, but this probably isn't a11y specific. With e10s enabled, you can no longer press alt+upArrow to collapse a combo box. You must press escape or enter. This works as expected with e10s disabled.

So the steps are:
1. Find a <select size="1"> combobox with some entries.
2. Press Alt+Down Arrow to expand. This works as expected.
3. Press Alt+UpArrow to collapse.

Expected: Combobox should collapse, and current selection should be reflected in the collapsed combobox.
Actual: Does not work.

4. Do the same with E10S disabled.

Result: Both keystrokes work as expected.

Comment 1

[Neil Deakin]

Attachment: Close popup on alt+up/down

Comment 2

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=025ddb842dbf

Comment 3

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01e32db35f6e

Comment 4

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a640765bbf0

Comment 5

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9af8f4f33471454d4e645f22900f50c64ddf4316
Bug 1314251, close menulist on alt+up/down, r=ksteuber

Comment 6

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a925f48bcc829d19b1c9f35d15c5a5f03b23b91c for eslint failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39364546&repo=mozilla-inbound

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6add5df4a48
Backed out changeset 9af8f4f33471

Comment 8

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7aba2499cb40fc8b0572f5f5c6cc997bcf234bdf
Bug 1314251, close menulist on alt+up/down, r=ksteuber

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7aba2499cb40

Comment 10

[areya]

https://hg.mozilla.org/mozilla-central/rev/7aba2499cb40

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Neil, is that something that we want to uplift to 52? Thanks

Comment 12

[Neil Deakin]

Comment on attachment 8808994 [details] [diff] [review]
Close popup on alt+up/down

Approval Request Comment
[Feature/Bug causing the regression]: e10s only
[User impact if declined]: inconsistent dropdown closing behaviour on e10s/non-e10s
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no, minor change
[Why is the change risky/not risky?]: no
[String changes made/needed]: no

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8808994 [details] [diff] [review]
Close popup on alt+up/down

close popup on alt+up, e10s regression fix for beta52

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/21d352f5869b