44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
The command `./manage.py collectstatic`  is being run without any config. It's fortunate this hasn't hurt us before but now, when we run it, we need access to GOOGLE_ANALYTICS_ID which is configured in settings/base.py and it's value comes from consulate socorro/webapp-django  https://github.com/mozilla/socorro/blob/af8f5ae090ecb4439131b860e18bd3e98df7280c/webapp-django/bin/bootstrap.sh#L18
Created attachment 8806313 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/3566
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/98e0558bf0762607e449304d98cc2aaed0499a10 bug 1314258 - run './manage.py collectstatic' with env vars (#3566) * bug 1314258 - run './manage.py collectstatic' with env vars * default in setting instead * cleaning up comment about hack
JP, I had to do something drastic to get the google analytics to work again. See PR mentioned/linked above. Ideally we should be executing the `./manage.py collectstatic` command WITH consulate setting all the environment variables. Can you figure out how to do that?
Changing this bug to be a P3. It's interesting, but probably not something we have time for. If there's a compelling reason why this has urgency and should get done now, please let us know in a comment!