1314258 - ./manage.py collectstatic run without environment variables

Status: RESOLVED WONTFIX

(Socorro :: Infra, task, P3)

Description

[Peter Bengtsson [:peterbe]]

The command `./manage.py collectstatic` [0] is being run without any config. 

It's fortunate this hasn't hurt us before but now, when we run it, we need access to GOOGLE_ANALYTICS_ID which is configured in settings/base.py and it's value comes from consulate socorro/webapp-django

[0] https://github.com/mozilla/socorro/blob/af8f5ae090ecb4439131b860e18bd3e98df7280c/webapp-django/bin/bootstrap.sh#L18

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3566

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/98e0558bf0762607e449304d98cc2aaed0499a10
bug 1314258 - run './manage.py collectstatic' with env vars (#3566)

* bug 1314258 - run './manage.py collectstatic' with env vars

* default in setting instead

* cleaning up comment about hack

Comment 3

[Peter Bengtsson [:peterbe]]

JP, I had to do something drastic to get the google analytics to work again. See PR mentioned/linked above. 

Ideally we should be executing the `./manage.py collectstatic` command WITH consulate setting all the environment variables. Can you figure out how to do that?

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Changing this bug to be a P3. It's interesting, but probably not something we have time for. If there's a compelling reason why this has urgency and should get done now, please let us know in a comment!

Comment 5

[Miles Crabill [:miles]]

At this point we could achieve this result in the new infrastructure without baking the GA ID into the code by injecting it into the Docker build process in CircleCI.