1314285 - Switch search scripts to use global versions

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Use python actions for search

When I originally did my search changes for Thunderbird, I used the same PY file in TB that I used in Firefox (so they were duplicated).

I've moved the files to a central location so we don't have to duplicate.

Comment 1

[Jorg K (CEST = GMT+2)]

Comment on attachment 8806357 [details] [diff] [review]
Use python actions for search

Thanks. That looks like a build issue of some sort ;-) I'd rather pass this in to Aleth. He's our build peer:
https://wiki.mozilla.org/Modules/MailNews_Core#Build_Config:_comm-central

Sorry, I'm not competent here.

Comment 2

[aleth [:aleth]]

Comment on attachment 8806357 [details] [diff] [review]
Use python actions for search

The removal of the mail/ copy of searchplugins.py doesn't seem to be in this patch yet? Please add this if it's no longer needed.

For future reference, you can also use MOZILLA_DIR to refer to the m-c root in a m-c/c-c independent way.

Comment 3

[Mike Kaply [:mkaply]]

I have the patch updated with removal and ready to go when the tree opens.

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to Mike Kaply [:mkaply] from comment #3)
> I have the patch updated with removal and ready to go when the tree opens.
The C-C tree opened again, so will you attach an updated patch?

Comment 5

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/comm-central/rev/1873dd731a68db04e4a71a4955c76d01fb552c43
Bug 1314285 - Use global version of search build files. r=aleth

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks. I guess we're done here then.