Closed
Bug 1314285
Opened 6 years ago
Closed 6 years ago
Switch search scripts to use global versions
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 52.0
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
1.73 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
When I originally did my search changes for Thunderbird, I used the same PY file in TB that I used in Firefox (so they were duplicated). I've moved the files to a central location so we don't have to duplicate.
Attachment #8806357 -
Flags: review?(jorgk)
Comment 1•6 years ago
|
||
Comment on attachment 8806357 [details] [diff] [review] Use python actions for search Thanks. That looks like a build issue of some sort ;-) I'd rather pass this in to Aleth. He's our build peer: https://wiki.mozilla.org/Modules/MailNews_Core#Build_Config:_comm-central Sorry, I'm not competent here.
Attachment #8806357 -
Flags: review?(jorgk) → review?(aleth)
Comment 2•6 years ago
|
||
Comment on attachment 8806357 [details] [diff] [review] Use python actions for search The removal of the mail/ copy of searchplugins.py doesn't seem to be in this patch yet? Please add this if it's no longer needed. For future reference, you can also use MOZILLA_DIR to refer to the m-c root in a m-c/c-c independent way.
Attachment #8806357 -
Flags: review?(aleth) → review+
Updated•6 years ago
|
Assignee: nobody → mozilla
Assignee | ||
Comment 3•6 years ago
|
||
I have the patch updated with removal and ready to go when the tree opens.
Comment 4•6 years ago
|
||
(In reply to Mike Kaply [:mkaply] from comment #3) > I have the patch updated with removal and ready to go when the tree opens. The C-C tree opened again, so will you attach an updated patch?
Assignee | ||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1873dd731a68db04e4a71a4955c76d01fb552c43 Bug 1314285 - Use global version of search build files. r=aleth
Comment 6•6 years ago
|
||
Thanks. I guess we're done here then.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in
before you can comment on or make changes to this bug.
Description
•