Closed Bug 1314299 Opened 5 years ago Closed 5 years ago

Add assertions to ConstraintTypeSet data structures

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

bug1314299-constraint-asserts
11.47 KB, patch
jandem
: review+
Details | Diff | Splinter Review 
To help track down bug 1220385 and following on from bug 1294767, I'd like to add some assertions to ConstraintTypeSet.
Here's a patch to add assert to ConstriantTypeSet to check for compartment mismatches when adding constraints and to check that the constraints are allocated in the correct lifo pools when sweeping.  Try seems green with this applied.
Attachment #8806366 - Flags: review?(jdemooij)
Comment on attachment 8806366 [details] [diff] [review]
bug1314299-constraint-asserts

Review of attachment 8806366 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8806366 - Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7aa1f0540760
Add assertions to ConstraintTypeSet data structures r=jandem
https://hg.mozilla.org/mozilla-central/rev/7aa1f0540760
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.