Closed
Bug 1314338
Opened 6 years ago
Closed 6 years ago
Disable OES_EGL_image extension on ATI drivers
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
Details
(Whiteboard: gfx)
Attachments
(1 file)
1.08 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
ATI drivers don't seem to actually have a function pointer to 'EGLImageTargetRenderbufferStorageOES'. After talking with jgilbert, we shouldn't be using this anywhere anyway, so disable this feature on ATI drivers. This also seems to correlate with this - https://bugzilla.mozilla.org/show_bug.cgi?id=1298333#c6 I'm on an AMD Radeon M395X and the user in bug 1298333 is on a Radeon HD 6310.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8806439 -
Flags: review?(jgilbert)
Assignee | ||
Updated•6 years ago
|
Whiteboard: gfx
Comment 2•6 years ago
|
||
Comment on attachment 8806439 [details] [diff] [review] ati.patch Review of attachment 8806439 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLContext.cpp @@ +1795,5 @@ > } > > + if (Vendor() == GLVendor::ATI) { > + // ATI drivers say this extension exists, but we can't > + // actually find the extension function pointer in the drivers. Specifically the renderbufferStorage entrypoint, since IIRC we could find the texture one? If not, this text is fine.
Attachment #8806439 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #2) > Comment on attachment 8806439 [details] [diff] [review] > ati.patch > > Review of attachment 8806439 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: gfx/gl/GLContext.cpp > @@ +1795,5 @@ > > } > > > > + if (Vendor() == GLVendor::ATI) { > > + // ATI drivers say this extension exists, but we can't > > + // actually find the extension function pointer in the drivers. > > Specifically the renderbufferStorage entrypoint, since IIRC we could find > the texture one? If not, this text is fine. Fixed. Try looks ok - https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4905c8cd005
Pushed by mchang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ba2826a444d4 Disable OES_EGL_image extension on ATI drivers. r=jgilbert
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ba2826a444d4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•