1314341 - Missing check for baseURI in ServiceWorkerManager::Register

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: sw.patch

I found this writing a browser mochitest. Probably this cannot be reproduced in 'normal' content pages.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8806440 [details] [diff] [review]
sw.patch

Review of attachment 8806440 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerContainer.cpp
@@ +202,5 @@
> +        nsAutoCString spec;
> +        scriptURI->GetSpec(spec);
> +        NS_ConvertUTF8toUTF16 wSpec(spec);
> +        aRv.ThrowTypeError<MSG_INVALID_SCOPE>(aOptions.mScope.Value(), wSpec);
> +      }

nit: Can you use ternary to set the URI pointer and then avoid duplicating the rest here?  Like:

  nsIURI* uri = baseURI ? baseURI : scriptURI;
  nsAutoCString spec;
  uri->GetSpec(spec);
  // etc

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd3745be7445
Missing check for baseURI in ServiceWorkerManager::Register, r=bkelly

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cd3745be7445