1314353 - Investigate possible correlation between Websense and Firefox compiled using VS 2015

Status: NEW

(Firefox Build System :: General, defect)

Description

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Brad mentioned a theory that the Websense crashes might have spiked in 48 due to the switch we made to using VS 2015 to compile Firefox.

Two ideas we want to explore in this bug:
1. We'd like to provide a try build for SoftVision to repro Websense crash. This will be a 47.0.2 build compiled using VS 2015. Florin has access to an installer of Triton Websense endpoint (perhaps an old version but still better than no repro in-house). 

2. We'd like to get a build of 50 (a potential 50.0.1) built off of VS 2013 (not sure if that's possible) to ship to only Websense users as potential mitigation strategy once 50 goes live.

Comment 1

[(not currently active) Ted Mielczarek]

bug 1186064 landed in the Firefox 50 cycle, and then a bunch of other bugs (marked as depending on it) landed in 50 as well, which removed code that was necessary to build with VC2013. I don't think getting Firefox 50 built with VC2013 is going to be feasible. At the very least you'd have to back out all of those patches.

Comment 2

[Rail Aliiev [:rail]]

<gps> ritu: IIRC we backed out VS2015 from 47. so it should be on VS2015 with minimal modifications. try reverting c75f82688e73
<gps> s/be/build
<gps> update to 47.0.2 locally, `hg backout c75f82688e73`, then push to try

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Yes, bug 1186060 originally landed on Fx48. However, that change was later reverted in bug 1270664 by rev c75f82688e73 as noted in comment 2. So wouldn't that indicate that this isn't an MSVC2015 issue? I can confirm locally that Firefox 48 still contains the MSVC2013 CRT DLLs while Firefox 49 has the 2015 ones.