1314399 - Assertion failure in nsRefreshDriver when the GPU process aborts

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Example: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=30215417

Assertion failure is here: http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/layout/base/nsRefreshDriver.cpp

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1314399.patch

I reviewed this but didn't read carefully enough: we allocate transaction ids in ForwardTransaction, but try to revoke them potentially before that in EndTransaction.

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8808384 [details] [diff] [review]
bug1314399.patch

Review of attachment 8808384 [details] [diff] [review]:
-----------------------------------------------------------------

ah, indeed!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/494b13143c3e
Fix revoking transactions that may not have been started. (bug 1314399, r=nical)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/494b13143c3e