Closed
Bug 1314399
Opened 8 years ago
Closed 8 years ago
Assertion failure in nsRefreshDriver when the GPU process aborts
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.52 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
Example: https://treeherder.mozilla.org/#/jobs?repo=try&author=danderson@mozilla.com&selectedJob=30215417 Assertion failure is here: http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/layout/base/nsRefreshDriver.cpp
|
Assignee | |
Comment 1•8 years ago
|
||
I reviewed this but didn't read carefully enough: we allocate transaction ids in ForwardTransaction, but try to revoke them potentially before that in EndTransaction.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Attachment #8808384 -
Flags: review?(nical.bugzilla)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8808384 [details] [diff] [review] bug1314399.patch Review of attachment 8808384 [details] [diff] [review]: ----------------------------------------------------------------- ah, indeed!
Attachment #8808384 -
Flags: review?(nical.bugzilla) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/494b13143c3e Fix revoking transactions that may not have been started. (bug 1314399, r=nical)
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/494b13143c3e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•