Closed Bug 1314399 Opened 4 years ago Closed 4 years ago

Assertion failure in nsRefreshDriver when the GPU process aborts

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch bug1314399.patchSplinter Review
I reviewed this but didn't read carefully enough: we allocate transaction ids in ForwardTransaction, but try to revoke them potentially before that in EndTransaction.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Attachment #8808384 - Flags: review?(nical.bugzilla)
Comment on attachment 8808384 [details] [diff] [review]
bug1314399.patch

Review of attachment 8808384 [details] [diff] [review]:
-----------------------------------------------------------------

ah, indeed!
Attachment #8808384 - Flags: review?(nical.bugzilla) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/494b13143c3e
Fix revoking transactions that may not have been started. (bug 1314399, r=nical)
https://hg.mozilla.org/mozilla-central/rev/494b13143c3e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.