1314453 - Piping output of mach eslint to another tool

Status: RESOLVED WORKSFORME

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Dave Townsend [:mossop]]

Run "mach eslint toolkit/mozapps/extensions | cat"

Error running mach:

    ['eslint', 'toolkit/mozapps/extensions']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 0: ordinal not in range(128)

  File "c:\mozilla\source\trunk\tools/lint/mach_commands.py", line 62, in eslint
    argv=extra_args, **kwargs)
  File "c:\mozilla\source\trunk\python/mach\mach\registrar.py", line 123, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "c:\mozilla\source\trunk\python/mach\mach\registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
  File "c:\mozilla\source\trunk\tools/lint/mach_commands.py", line 43, in lint
    return cli.run(*runargs, **lintargs)
  File "c:\mozilla\source\trunk\python/mozlint\mozlint\cli.py", line 108, in run
    print(formatter(results).encode('utf-8', 'replace'))
  File "c:\mozilla-build\python\lib\codecs.py", line 369, in write
    data, consumed = self.encode(object, self.errors)

Comment 1

[Mark Banner (:standard8)]

This happens on Mac as well...

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Possibly running |export PYTHONIOENCODING=utf-8| works around this issue.

Comment 3

[Mark Banner (:standard8)]

I believe this is now working fine. I know Andrew did some changes a while ago to mozlint out, so I suspect that fixed it.