Closed
Bug 1314454
Opened 9 years ago
Closed 7 years ago
Mozreview doesn't display encoding changes
Categories
(MozReview Graveyard :: Review Board: DiffViewer, defect)
MozReview Graveyard
Review Board: DiffViewer
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: glandium, Unassigned)
Details
Attachments
(1 file)
|
6.05 KB,
patch
|
Details | Diff | Splinter Review |
See https://reviewboard.mozilla.org/r/89290/diff/2#index_header
vs. https://reviewboard.mozilla.org/r/89290/diff/raw/
The diff viewer claims only whitespace changes happened, while the actual changes convert ISO-8859-1 to utf-8, and don't touch any whitespace.
|
||
Comment 1•9 years ago
|
||
Serious question: does any code review tool report encoding changes?
|
Reporter | |
Comment 2•9 years ago
|
||
Let's see what splinter does with the same patch...
|
|
Reporter | |
Comment 3•9 years ago
|
||
So for splinter, the answer is yes, although it uses iso-8859-1 as encoding for the whole thing, so the utf-8 result looks garbled.
|
||
Comment 4•7 years ago
|
||
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•