1314476 - Fix numerous app update eslint errors

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

More eslint will be coming in the future so I went ahead and fixed a bunch in app update.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch - client code

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch - test code

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=53f070fbe8dd7938f2cc26e776f49433c4d7d10a

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8806560 [details] [diff] [review]
patch - client code

Linux tests have already passed on try and the tests passed locally on Windows so requesting review before try has finished.

Comment 5

[Robert Strong (they/them - no direct email)]

BTW: creating a patch with --ignore-space-change didn't significantly reduce the patch size. :(

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d356a4425cee
client code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2cfcf2315dd
test code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell

Comment 7

[Robert Strong (they/them - no direct email)]

I have a couple more to do.

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch - more test code

This should be the last of it. Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/623739146f22
additional test code cleanup - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d356a4425cee
https://hg.mozilla.org/mozilla-central/rev/d2cfcf2315dd
https://hg.mozilla.org/mozilla-central/rev/623739146f22