Closed Bug 1314476 Opened 6 years ago Closed 6 years ago

Fix numerous app update eslint errors

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(3 files)

patch - client code
7.58 KB, patch
mhowell
: review+
Details | Diff | Splinter Review
patch - test code
78.34 KB, patch
mhowell
: review+
Details | Diff | Splinter Review
patch - more test code
14.20 KB, patch
mhowell
: review+
Details | Diff | Splinter Review 
More eslint will be coming in the future so I went ahead and fixed a bunch in app update.
Comment on attachment 8806560 [details] [diff] [review]
patch - client code

Linux tests have already passed on try and the tests passed locally on Windows so requesting review before try has finished.
Attachment #8806560 - Flags: review?(mhowell)
Attachment #8806561 - Flags: review?(mhowell)
BTW: creating a patch with --ignore-space-change didn't significantly reduce the patch size. :(
Attachment #8806560 - Flags: review?(mhowell) → review+
Attachment #8806561 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d356a4425cee
client code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2cfcf2315dd
test code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
I have a couple more to do.
Keywords: leave-open
This should be the last of it. Thanks!
Attachment #8806830 - Flags: review?(mhowell)
Attachment #8806830 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/623739146f22
additional test code cleanup - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
status-firefox52: --- → fixed
Keywords: leave-open
Target Milestone: --- → mozilla52
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.