Closed
Bug 1314476
Opened 5 years ago
Closed 5 years ago
Fix numerous app update eslint errors
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(3 files)
|
7.58 KB,
patch
|
mhowell
:
review+
|
Details | Diff | Splinter Review |
|
78.34 KB,
patch
|
mhowell
:
review+
|
Details | Diff | Splinter Review |
|
14.20 KB,
patch
|
mhowell
:
review+
|
Details | Diff | Splinter Review |
More eslint will be coming in the future so I went ahead and fixed a bunch in app update.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=53f070fbe8dd7938f2cc26e776f49433c4d7d10a
|
|
Assignee | |
Comment 4•5 years ago
|
||
Comment on attachment 8806560 [details] [diff] [review] patch - client code Linux tests have already passed on try and the tests passed locally on Windows so requesting review before try has finished.
Attachment #8806560 -
Flags: review?(mhowell)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8806561 -
Flags: review?(mhowell)
|
|
Assignee | |
Comment 5•5 years ago
|
||
BTW: creating a patch with --ignore-space-change didn't significantly reduce the patch size. :(
|
||
Updated•5 years ago
|
Attachment #8806560 -
Flags: review?(mhowell) → review+
|
|
||
Updated•5 years ago
|
Attachment #8806561 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d356a4425cee client code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/d2cfcf2315dd test code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
|
|
Assignee | |
Comment 8•5 years ago
|
||
This should be the last of it. Thanks!
Attachment #8806830 -
Flags: review?(mhowell)
|
|
||
Updated•5 years ago
|
Attachment #8806830 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/623739146f22 additional test code cleanup - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d356a4425cee https://hg.mozilla.org/mozilla-central/rev/d2cfcf2315dd https://hg.mozilla.org/mozilla-central/rev/623739146f22
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•