Fix numerous app update eslint errors

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
Application Update
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(3 attachments)

More eslint will be coming in the future so I went ahead and fixed a bunch in app update.
Comment on attachment 8806560 [details] [diff] [review]
patch - client code

Linux tests have already passed on try and the tests passed locally on Windows so requesting review before try has finished.
Attachment #8806560 - Flags: review?(mhowell)
Attachment #8806561 - Flags: review?(mhowell)
BTW: creating a patch with --ignore-space-change didn't significantly reduce the patch size. :(

Updated

2 years ago
Attachment #8806560 - Flags: review?(mhowell) → review+

Updated

2 years ago
Attachment #8806561 - Flags: review?(mhowell) → review+

Comment 6

2 years ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d356a4425cee
client code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2cfcf2315dd
test code - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
I have a couple more to do.
Keywords: leave-open
Created attachment 8806830 [details] [diff] [review]
patch - more test code

This should be the last of it. Thanks!
Attachment #8806830 - Flags: review?(mhowell)

Updated

2 years ago
Attachment #8806830 - Flags: review?(mhowell) → review+

Comment 9

2 years ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/623739146f22
additional test code cleanup - Bug 1314476 - Fix numerous app update eslint errors. r=mhowell
status-firefox52: --- → fixed
Keywords: leave-open
Target Milestone: --- → mozilla52
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.