1314477 - --enable-rust builds shouldn't touch the network

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

My network connection went down, and my build failed. I thought this wasn't supposed to happen in our particular usage of rust?

 0:31.52 force-cargo-build
 0:31.96     Updating registry `https://github.com/rust-lang/crates.io-index`
 0:31.99 warning: spurious network error (2 tries remaining): [2/-1] failed to send request: The server name or address could not be resolved
 0:31.99
 0:31.99 warning: spurious network error (1 tries remaining): [2/-1] failed to send request: The server name or address could not be resolved
 0:31.99
 0:32.00 error: failed to fetch `https://github.com/rust-lang/crates.io-index`
 0:32.00
 0:32.00 Caused by:
 0:32.00   [2/-1] failed to send request: The server name or address could not be resolved
 0:32.01
 0:32.01 d:/build/msys/s/inbound/config/rules.mk:930: recipe for target 'force-cargo-build' failed
 0:32.01 mozmake.EXE[5]: *** [force-cargo-build] Error 101
 0:32.01 d:/build/msys/s/inbound/config/recurse.mk:71: recipe for target 'toolkit/library/rust/target' failed

m-i cd3745be7445

$ cat $MOZCONFIG
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj/win64
ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32
ac_add_options --enable-rust

Comment 1

[Nathan Froyd [:froydnj]]

What rust version, and in particular, what cargo version are you using?

Comment 2

[(Away)]

rustc 1.11.0 (9b21dcd6a 2016-08-15)
cargo 0.12.0-nightly (6b98d1f 2016-07-04)

A bit old, I admit, but configure has never yelled at me about them.

Comment 3

[(not currently active) Ted Mielczarek]

We don't require Rust 1.12, but Rust 1.12 is the first version of Rust whose cargo is new enough to support the source replacement feature we're using for our vendored crates.

We talked about requiring Rust 1.12 so we could use cargo workspaces.

Comment 4

[(not currently active) Ted Mielczarek]

bug 1302704 is going to make us require cargo 0.14, which supports --frozen and will make this go away.

Comment 5

[Nathan Froyd [:froydnj]]

We now use --frozen everywhere.  If this happens again, we can open a separate bug for it, because that'd be a problem with cargo!