signal 11 was received by running dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/indexedstatequery.html

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: vliu, Assigned: vliu)

Tracking

unspecified
mozilla52
ARM
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51+ fixed, firefox52 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Updated

3 years ago
Assignee: nobody → vliu
Assignee

Comment 1

3 years ago
Posted file stack-dump.log
Stack dump was attached.
Assignee

Comment 2

3 years ago
Hi Morris,

The crash happens because linkInfo became dangling but still operating its member functions. Could you please have a review? Thanks.
Attachment #8806618 - Flags: review?(mtseng)
Comment on attachment 8806618 [details] [diff] [review]
Add raw pointer check to avoid operating with nullptr.

Review of attachment 8806618 [details] [diff] [review]:
-----------------------------------------------------------------

You should check IsLinked() and return invalid operation like http://searchfox.org/mozilla-central/source/dom/canvas/WebGLProgram.cpp#863-866
Attachment #8806618 - Flags: review?(mtseng) → review-
Assignee

Comment 4

3 years ago
Thanks the comments for the patch. Could you please also have a review?
Attachment #8806646 - Flags: review?(mtseng)
Assignee

Updated

3 years ago
Attachment #8806618 - Attachment is obsolete: true
Attachment #8806646 - Flags: review?(mtseng) → review+

Comment 6

3 years ago
Pushed by vliu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1de4471e4b
Execute ErrorInvalidOperation if IsLinked() returns false. r=mtseng

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b1de4471e4b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee

Comment 8

3 years ago
[Tracking Requested - why for this release]:This bug is for fixing webgl2 conformance test crashed. We need this fix uplift to FF-51.
Track 51+ as this is Web GL 2 conformance test. 

Hi :vliu, 
Do you think this is worth uplifting to 51 aurora?
Flags: needinfo?(vliu)
Comment on attachment 8806646 [details] [diff] [review]
Execute ErrorInvalidOperation if IsLinked() returns false.

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:
Flags: needinfo?(vliu)
Attachment #8806646 - Flags: approval-mozilla-aurora?
Comment on attachment 8806646 [details] [diff] [review]
Execute ErrorInvalidOperation if IsLinked() returns false.

Crash fix for WebGL2, let's uplift to aurora.
Attachment #8806646 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee

Updated

3 years ago
Blocks: webgl2
You need to log in before you can comment on or make changes to this bug.