1314505 - signal 11 was received by running dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/indexedstatequery.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Vincent Liu[:vliu]]

This issue can be reproduced by loading the html file in [1].

[1]: https://dxr.mozilla.org/mozilla-central/source/dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/indexedstatequery.html?q=path%3Aindexedstatequery.html&redirect_type=single

Comment 1

[Vincent Liu[:vliu]]

Attachment: stack-dump.log

Stack dump was attached.

Comment 2

[Vincent Liu[:vliu]]

Attachment: Add raw pointer check to avoid operating with nullptr.

Hi Morris,

The crash happens because linkInfo became dangling but still operating its member functions. Could you please have a review? Thanks.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8806618 [details] [diff] [review]
Add raw pointer check to avoid operating with nullptr.

Review of attachment 8806618 [details] [diff] [review]:
-----------------------------------------------------------------

You should check IsLinked() and return invalid operation like http://searchfox.org/mozilla-central/source/dom/canvas/WebGLProgram.cpp#863-866

Comment 4

[Vincent Liu[:vliu]]

Attachment: Execute ErrorInvalidOperation if IsLinked() returns false.

Thanks the comments for the patch. Could you please also have a review?

Comment 5

[Vincent Liu[:vliu]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=badf6e942641&selectedJob=30356415

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1de4471e4b
Execute ErrorInvalidOperation if IsLinked() returns false. r=mtseng

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4b1de4471e4b

Comment 8

[Vincent Liu[:vliu]]

[Tracking Requested - why for this release]:This bug is for fixing webgl2 conformance test crashed. We need this fix uplift to FF-51.

Comment 9

[Gerry Chang [:gchang]]

Track 51+ as this is Web GL 2 conformance test. 

Hi :vliu, 
Do you think this is worth uplifting to 51 aurora?

Comment 10

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8806646 [details] [diff] [review]
Execute ErrorInvalidOperation if IsLinked() returns false.

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8806646 [details] [diff] [review]
Execute ErrorInvalidOperation if IsLinked() returns false.

Crash fix for WebGL2, let's uplift to aurora.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/239548496f8e