signal 11 was received by running dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/indexedstatequery.html

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: vliu, Assigned: vliu)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
ARM
Linux
Points:
---

Firefox Tracking Flags

(firefox51+ fixed, firefox52 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Updated

2 years ago
Assignee: nobody → vliu
(Assignee)

Comment 1

2 years ago
Created attachment 8806589 [details]
stack-dump.log

Stack dump was attached.
(Assignee)

Comment 2

2 years ago
Created attachment 8806618 [details] [diff] [review]
Add raw pointer check to avoid operating with nullptr.

Hi Morris,

The crash happens because linkInfo became dangling but still operating its member functions. Could you please have a review? Thanks.
Attachment #8806618 - Flags: review?(mtseng)
Comment on attachment 8806618 [details] [diff] [review]
Add raw pointer check to avoid operating with nullptr.

Review of attachment 8806618 [details] [diff] [review]:
-----------------------------------------------------------------

You should check IsLinked() and return invalid operation like http://searchfox.org/mozilla-central/source/dom/canvas/WebGLProgram.cpp#863-866
Attachment #8806618 - Flags: review?(mtseng) → review-
(Assignee)

Comment 4

2 years ago
Created attachment 8806646 [details] [diff] [review]
Execute ErrorInvalidOperation if IsLinked() returns false.

Thanks the comments for the patch. Could you please also have a review?
Attachment #8806646 - Flags: review?(mtseng)
(Assignee)

Updated

2 years ago
Attachment #8806618 - Attachment is obsolete: true
Attachment #8806646 - Flags: review?(mtseng) → review+

Comment 6

2 years ago
Pushed by vliu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1de4471e4b
Execute ErrorInvalidOperation if IsLinked() returns false. r=mtseng

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b1de4471e4b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Assignee)

Comment 8

2 years ago
[Tracking Requested - why for this release]:This bug is for fixing webgl2 conformance test crashed. We need this fix uplift to FF-51.
tracking-firefox51: --- → ?
Track 51+ as this is Web GL 2 conformance test. 

Hi :vliu, 
Do you think this is worth uplifting to 51 aurora?
status-firefox51: --- → affected
tracking-firefox51: ? → +
Flags: needinfo?(vliu)
Comment on attachment 8806646 [details] [diff] [review]
Execute ErrorInvalidOperation if IsLinked() returns false.

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:
Flags: needinfo?(vliu)
Attachment #8806646 - Flags: approval-mozilla-aurora?
Comment on attachment 8806646 [details] [diff] [review]
Execute ErrorInvalidOperation if IsLinked() returns false.

Crash fix for WebGL2, let's uplift to aurora.
Attachment #8806646 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 12

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/239548496f8e
status-firefox51: affected → fixed
(Assignee)

Updated

2 years ago
Blocks: 889977
You need to log in before you can comment on or make changes to this bug.