131452 - remove "layout.forms.use_standard_or_quirks" pref

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Do we need the "layout.forms.use_standard_or_quirks" pref anymore?  There's a
lot of code that's not triggered unless that pref is set to true, and I suspect
that code is gradually bitrotting.  I'll attach a patch that removes it.

Thoughts?

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (diff -u, for testing / checking in)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (diff -uw, for review)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to quirk.css

Oops, I missed the quirk.css changes.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch updated to current trunk (diff -u)

This patch isn't really any different -- it just resolves a conflict where
another change was nearby.

Comment 5

[rods (gone)]

Comment on attachment 75288 [details] [diff] [review]
patch updated to current trunk (diff -u)

Since we are not using it, we should do away with it. Might want to run it by
mkaply, but I am sure OS2 isn't using Quirkss anymore. r=rods

Comment 6

[Marc Attinasi]

Comment on attachment 75288 [details] [diff] [review]
patch updated to current trunk (diff -u)

Why the '#if 1' in nsGfxButtonControlFrame.cpp? 

sr=attinasi

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The |#if 1| was a transformation of this:

-    nsCompatibility mode = eCompatibility_NavQuirks;
-    //nsFormControlHelper::GetFormCompatibilityMode(aPresContext, mode);

since I thought that people might still want the "standards" codepath at some
point in the future (although I'm not sure what the difference is).

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 75288 [details] [diff] [review]
patch updated to current trunk (diff -u)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2002-03-26 22:13 PST.

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 130637 has been marked as a duplicate of this bug. ***