Closed Bug 1314524 Opened 3 years ago Closed 3 years ago

Remove unused dormant code from MDSM

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(7 files)

We are able to remove unused dormant code from MDSM after fixing bug 1311872.
Assignee: nobody → jwwang
Blocks: 1286129
Depends on: 1311872
Priority: -- → P3
Attachment #8806999 - Flags: review?(kaku)
Attachment #8807000 - Flags: review?(kaku)
Attachment #8807001 - Flags: review?(kaku)
Attachment #8807002 - Flags: review?(kaku)
Attachment #8807003 - Flags: review?(kaku)
Attachment #8807004 - Flags: review?(kaku)
Attachment #8807005 - Flags: review?(kaku)
Comment on attachment 8806999 [details]
Bug 1314524. Part 1 - remove MDSM::SetDormant() which has no callers.

https://reviewboard.mozilla.org/r/90240/#review91076
Attachment #8806999 - Flags: review?(kaku) → review+
Comment on attachment 8807000 [details]
Bug 1314524. Part 2 - devirtualize StateObject::HandleDormant().

https://reviewboard.mozilla.org/r/90242/#review91078
Attachment #8807000 - Flags: review?(kaku) → review+
Comment on attachment 8807001 [details]
Bug 1314524. Part 3 - add DecodingState::EnterDormant().

https://reviewboard.mozilla.org/r/90244/#review91080
Attachment #8807001 - Flags: review?(kaku) → review+
Comment on attachment 8807002 [details]
Bug 1314524. Part 4 - remove DormantState::HandleDormant().

https://reviewboard.mozilla.org/r/90246/#review91082
Attachment #8807002 - Flags: review?(kaku) → review+
Comment on attachment 8807003 [details]
Bug 1314524. Part 5 - remove unused HandleDormant() functions.

https://reviewboard.mozilla.org/r/90248/#review91084
Attachment #8807003 - Flags: review?(kaku) → review+
Comment on attachment 8807004 [details]
Bug 1314524. Part 6 - remove unused mPendingDormant.

https://reviewboard.mozilla.org/r/90250/#review91086
Attachment #8807004 - Flags: review?(kaku) → review+
Comment on attachment 8807005 [details]
Bug 1314524. Part 7 - fix comments about dormant.

https://reviewboard.mozilla.org/r/90252/#review91088
Attachment #8807005 - Flags: review?(kaku) → review+
Thanks for the simplification, this is the first time that I think I know something about dormant!
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53e37c0bc34b
Part 1 - remove MDSM::SetDormant() which has no callers. r=kaku
https://hg.mozilla.org/integration/autoland/rev/5e7a0cfc6d9c
Part 2 - devirtualize StateObject::HandleDormant(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/16b66da55180
Part 3 - add DecodingState::EnterDormant(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/a92a74c529f9
Part 4 - remove DormantState::HandleDormant(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/a234387116d1
Part 5 - remove unused HandleDormant() functions. r=kaku
https://hg.mozilla.org/integration/autoland/rev/8715720a9ac2
Part 6 - remove unused mPendingDormant. r=kaku
https://hg.mozilla.org/integration/autoland/rev/85aba58a1144
Part 7 - fix comments about dormant. r=kaku
You need to log in before you can comment on or make changes to this bug.