Closed Bug 1314529 Opened 4 years ago Closed 4 years ago

HTMLMediaElement::InitializeDecoderAsClone() shouldn't call MediaDecoder::SetMediaSeekable()

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/dom/html/HTMLMediaElement.cpp#3710

MediaDecoder will discover whether the media is seekable or not on the way of decoding. HTMLMediaElement doesn't need to set it explicitly when cloning a MediaDecoder.
Assignee: nobody → jwwang
Blocks: 1286129
Priority: -- → P3
Attachment #8807014 - Flags: review?(cpearce)
Attachment #8807015 - Flags: review?(cpearce)
Comment on attachment 8807014 [details]
Bug 1314529. Part 1 - remove the call to MediaDecoder::SetMediaSeekable().

https://reviewboard.mozilla.org/r/90276/#review90238
Attachment #8807014 - Flags: review?(cpearce) → review+
Comment on attachment 8807015 [details]
Bug 1314529. Part 2 - remove MediaDecoder::SetMediaSeekable().

https://reviewboard.mozilla.org/r/90278/#review90240
Attachment #8807015 - Flags: review?(cpearce) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d53bf4f3712
Part 1 - remove the call to MediaDecoder::SetMediaSeekable(). r=cpearce
https://hg.mozilla.org/integration/autoland/rev/43d87e61c0cf
Part 2 - remove MediaDecoder::SetMediaSeekable(). r=cpearce
https://hg.mozilla.org/mozilla-central/rev/7d53bf4f3712
https://hg.mozilla.org/mozilla-central/rev/43d87e61c0cf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.