Closed Bug 1314539 Opened 3 years ago Closed 3 years ago

Unify license files and Mozilla license headers in vendor directory

Categories

(DevTools :: Shared Components, defect, P2)

defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: Honza, Assigned: dalimil)

Details

Attachments

(1 file, 1 obsolete file)

This is a follow up for bug 1312481

The following should be made consistent.

1) We have an extra license files for react libs in the directory (e.g. REDUX_LICENSE and REACT_REDUX_LICENSE). But other libs in the directory don't do that.

2) Some files in the directory (e.g. REACT_VIRTUALIZED_UPGRADING file) doesn't have Mozilla license header at the top. Other files have that.

Honza
Priority: -- → P2
Attached patch Bug1314539.patch - rev1 (obsolete) — Splinter Review
I added the Mozilla license to the *_UPGRADING files and removed the duplicate LICENSE file.
Assignee: nobody → dalimilhajek
Status: NEW → ASSIGNED
Attachment #8808158 - Flags: review?(odvarko)
Comment on attachment 8808158 [details] [diff] [review]
Bug1314539.patch - rev1

Review of attachment 8808158 [details] [diff] [review]:
-----------------------------------------------------------------

Please keep REACT_REDUX_LICENSE file in. I believe it should be there. It's the same license,
but for for different module (React vs. React-redux)

Honza
Attachment #8808158 - Flags: review?(odvarko)
Gerv, I was quickly looking at: https://www.mozilla.org/en-US/MPL/headers/
and the page talks about (a) new code and (b) test scripts and other short code examples. They both have slightly different license headers.

What license header should be used for a file that contains mostly information about how to upgrade things. See e.g. this file:
https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/vendor/REACT_UPGRADING

The one for 'new code' or 'test scripts and other short code examples' ? 

Honza
Flags: needinfo?(gerv)
(In reply to Jan Honza Odvarko [:Honza] from comment #3)
> The one for 'new code' or 'test scripts and other short code examples' ? 

Anything which is not a "test script and other short code example" falls into the "new code" bucket.

Gerv
Flags: needinfo?(gerv)
@Dalimil: the patch looks good, but do not remove the REACT_REDUX_LICENSE file (see also my comment #2)

Honza
Flags: needinfo?(dalimilhajek)
OK, I put the license file back.
Attachment #8808158 - Attachment is obsolete: true
Flags: needinfo?(dalimilhajek)
Attachment #8810881 - Flags: review?(odvarko)
Comment on attachment 8810881 [details] [diff] [review]
Bug1314539.patch - rev2

Review of attachment 8810881 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Honza
Attachment #8810881 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60bb7c019127
Unify license files and Mozilla license headers in vendor directory. r=odvarko
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/60bb7c019127
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.