1314539 - Unify license files and Mozilla license headers in vendor directory

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1312481

The following should be made consistent.

1) We have an extra license files for react libs in the directory (e.g. REDUX_LICENSE and REACT_REDUX_LICENSE). But other libs in the directory don't do that.

2) Some files in the directory (e.g. REACT_VIRTUALIZED_UPGRADING file) doesn't have Mozilla license header at the top. Other files have that.

Honza

Comment 1

[Dalimil Hajek [:dalimil]]

Attachment: Bug1314539.patch - rev1

I added the Mozilla license to the *_UPGRADING files and removed the duplicate LICENSE file.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8808158 [details] [diff] [review]
Bug1314539.patch - rev1

Review of attachment 8808158 [details] [diff] [review]:
-----------------------------------------------------------------

Please keep REACT_REDUX_LICENSE file in. I believe it should be there. It's the same license,
but for for different module (React vs. React-redux)

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Gerv, I was quickly looking at: https://www.mozilla.org/en-US/MPL/headers/
and the page talks about (a) new code and (b) test scripts and other short code examples. They both have slightly different license headers.

What license header should be used for a file that contains mostly information about how to upgrade things. See e.g. this file:
https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/vendor/REACT_UPGRADING

The one for 'new code' or 'test scripts and other short code examples' ? 

Honza

Comment 4

[Gervase Markham [:gerv]]

(In reply to Jan Honza Odvarko [:Honza] from comment #3)
> The one for 'new code' or 'test scripts and other short code examples' ? 

Anything which is not a "test script and other short code example" falls into the "new code" bucket.

Gerv

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Dalimil: the patch looks good, but do not remove the REACT_REDUX_LICENSE file (see also my comment #2)

Honza

Comment 6

[Dalimil Hajek [:dalimil]]

Attachment: Bug1314539.patch - rev2

OK, I put the license file back.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8810881 [details] [diff] [review]
Bug1314539.patch - rev2

Review of attachment 8810881 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Honza

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60bb7c019127
Unify license files and Mozilla license headers in vendor directory. r=odvarko

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60bb7c019127

Comment 10

[areya]

https://hg.mozilla.org/mozilla-central/rev/60bb7c019127