Closed
Bug 1314551
Opened 8 years ago
Closed 8 years ago
Let the Identity dialog title differentiate between New and Edit.
Categories
(MailNews Core :: Account Manager, defect)
MailNews Core
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 52.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 2 obsolete files)
7.20 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Like in bug 1312262 we should on Identity dialog title differentiate between "New Identity" and "Edit identity name <address>".
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8806639 -
Flags: review?(iann_bugzilla)
Attachment #8806639 -
Flags: review?(acelists)
Assignee | ||
Comment 2•8 years ago
|
||
Oops found a missing semicolon. Is there a more elegant way for: let listName = gIdentity.fullName + " <" + gIdentity.email + ">"; Or is this okay?
Attachment #8806639 -
Attachment is obsolete: true
Attachment #8806639 -
Flags: review?(iann_bugzilla)
Attachment #8806639 -
Flags: review?(acelists)
Attachment #8806643 -
Flags: review?(iann_bugzilla)
Attachment #8806643 -
Flags: review?(acelists)
So where is the meta bug I requested where the rules for these titles are agreed upon? ;)
Comment on attachment 8806643 [details] [diff] [review] Identity.patch v1a Review of attachment 8806643 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/locales/en-US/chrome/messenger/prefs.properties @@ +67,5 @@ > identity-list-title=Identities for %1$S > > +identityDialogTitleAdd= New Identity > +## LOCALIZATION NOTE (identityDialogTitleEdit): %S is the identity name > +identityDialogTitleEdit= Edit %S Why are there leading spaces? ::: mailnews/base/prefs/content/am-identity-edit.js @@ +27,5 @@ > accountDialog.getElementById("accountManager").clientHeight + "px"; > } > > + if (gIdentity) { > + let listName = gIdentity.fullName + " <" + gIdentity.email + ">"; There is gIdentity.identityName for this. ::: suite/locales/en-US/chrome/mailnews/pref/prefs.properties @@ +68,5 @@ > identity-list-title=Identities for %1$S > > +identityDialogTitleAdd= New Identity > +## LOCALIZATION NOTE (identityDialogTitleEdit): %S is the identity name > +identityDialogTitleEdit= Edit %S Why are there leading spaces?
Attachment #8806643 -
Flags: review?(acelists) → review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to :aceman from comment #4) > Comment on attachment 8806643 [details] [diff] [review] > Identity.patch v1a > > Review of attachment 8806643 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mail/locales/en-US/chrome/messenger/prefs.properties > @@ +67,5 @@ > > identity-list-title=Identities for %1$S > > > > +identityDialogTitleAdd= New Identity > > +## LOCALIZATION NOTE (identityDialogTitleEdit): %S is the identity name > > +identityDialogTitleEdit= Edit %S > > Why are there leading spaces? Probably because JS needs the space. Fixed > ::: mailnews/base/prefs/content/am-identity-edit.js > @@ +27,5 @@ > > accountDialog.getElementById("accountManager").clientHeight + "px"; > > } > > > > + if (gIdentity) { > > + let listName = gIdentity.fullName + " <" + gIdentity.email + ">"; > > There is gIdentity.identityName for this. Changed to this. > ::: suite/locales/en-US/chrome/mailnews/pref/prefs.properties > @@ +68,5 @@ > > identity-list-title=Identities for %1$S > > > > +identityDialogTitleAdd= New Identity > > +## LOCALIZATION NOTE (identityDialogTitleEdit): %S is the identity name > > +identityDialogTitleEdit= Edit %S > > Why are there leading spaces? Fixed
Attachment #8806643 -
Attachment is obsolete: true
Attachment #8806643 -
Flags: review?(iann_bugzilla)
Attachment #8807855 -
Flags: review?(iann_bugzilla)
Comment on attachment 8807855 [details] [diff] [review] Identity.patch v2 LGTM r/a=me
Attachment #8807855 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1a44c4a7690733cadf5dd28090e58da04f15abe7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in
before you can comment on or make changes to this bug.
Description
•