1314599 - Update the new debugger's L10N support

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P1)

Description

[Jason Laster [:jlast]]

This does two things:
1. passes L10N into the debugger's bootstrap function
2. switches to multilocalization so that the sourceeditor properties can also be used. We need them so that we can localize shortcuts such as findNext. I don't think we want to add these properties to the debugger properties file because that could trigger a re-translation.

Comment 1

[Jason Laster [:jlast]]

Attachment: update-l10n.patch

Comment 2

[James Long (:jlongster)]

Comment on attachment 8806708 [details] [diff] [review]
update-l10n.patch

Review of attachment 8806708 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/debugger/new/panel.js
@@ +8,5 @@
> +
> +var L10N = new MultiLocalizationHelper(
> +  "devtools/locale/debugger.properties",
> +  "devtools/locale/sourceeditor.properties",
> +);

Awesome, this looks like a good step. What do you think about moving this into `DebuggerPanel.prototype.open` ? That way we're not loading and parsing the strings when the toolbox opens, but only when the debugger is actually loaded. Since we can't use L10N before we call `bootstrap` anyway, that should work.

Comment 3

[Jason Laster [:jlast]]

Attachment: update-l10n2.patch

Comment 4

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=debdd822712a232d1ddcb63ec1a3206ed5f505cb

Comment 5

[James Long (:jlongster)]

Comment on attachment 8808332 [details] [diff] [review]
update-l10n2.patch

Review of attachment 8808332 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!