1314663 - Disabled checkbox results no Network panel for WebExtensions

Status: RESOLVED WORKSFORME

(DevTools :: Netmonitor, defect)

Description

[Ag]

Attachment: ff-net.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393

Steps to reproduce:

I tried to open network panel for my WebExtension.
Checkbox is disabled an checked.


Actual results:

There is no Network tab.


Expected results:

Tab should be visible.
Maybe it's not visible, because the checkbox (show network) is disabled...

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

This is very likely not a WebExtensions-specific bug on its own, we don't customize the enabled/disabled panels for the "Addon Debugging" windows, it may be an issue triggered by opening another toolbox that doesn't support the Network panel (e.g. the Browser Content toolbox doesn't provide this panel).

Hi Jan, 
do you know if this is a known issue that has already been reported for other kind of devtools toolboxes?
(or who would be a good person to investigate which is the actual underlying issue)

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Network panel is not enabled for Addon Toolboxes.

You can see this place (networkMonitor: false):
https://searchfox.org/mozilla-central/rev/a0333927deabfe980094a14d0549b589f34cbe49/devtools/server/actors/targets/addon.js#100{

@Alex: what it the blocker for Addon toolboxes to have the Network panel?

Also, I can actually see the panel (and other panels) for `Form Autofill` (system extension),
but not for any other (system) extension. Why is the `Form Autofill` special?

Honza

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> The Network panel is not enabled for Addon Toolboxes.
> 
> You can see this place (networkMonitor: false):
> https://searchfox.org/mozilla-central/rev/
> a0333927deabfe980094a14d0549b589f34cbe49/devtools/server/actors/targets/
> addon.js#100{

That is only used for legacy extensions (e.g. bootstrap based extensions, or hybrid bootstrap-based extensions with an embedded webextension), the one used for the WebExtensions (and WebExtensions with an embedded experiments API) is the WebExtensionActor, here is were we create the addon actor instance based on the type of extension:

https://searchfox.org/mozilla-central/rev/a0333927deabfe980094a14d0549b589f34cbe49/devtools/server/actors/webbrowser.js#686-690
 
> @Alex: what it the blocker for Addon toolboxes to have the Network panel?

The Network panel is supported on the WebExtensions targets, the following is a mochitest-browser test that covers it:

- https://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_addon_debugging_netmonitor.js
 
> Also, I can actually see the panel (and other panels) for `Form Autofill`
> (system extension),
> but not for any other (system) extension. Why is the `Form Autofill` special?

'Form AutoFill' has been already converted to a "WebExtension with an embedded experiments API" (https://searchfox.org/mozilla-central/source/browser/extensions/formautofill/manifest.json), whereas the other system addons that doesn't have a network panel are likely still bootstrap-based extensions or hybrid bootstrap-based extensions with an embedded webextension.

Comment 4

[Alexandre Poirot [:ochameau]]

I can see the netmonitor working for all my webextension.
Is it failing to display because Ag's extension is a special one? Hybrid of something?
Or is there a STR to reproduce this with a common webextension?

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm closing this issue as worksforme for now, as we are not able to reproduce it and the original bug report is from a pretty old version of Firefox (as it can be noticed from the attached screenshot).

Ag, 
feel free to re-open if you are still experiencing this issue and you can provide some additional details to reproduce the issue (e.g. if there is a particular extension or sequence of steps that is still able to trigger this issue).

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Clearing old needinfo request.