Closed Bug 1314670 Opened 8 years ago Closed 7 years ago

Intermittent browser/components/search/test/browser_amazon_behavior.js | Test timed out -

Categories

(Firefox :: Search, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: standard8)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown][fxsearch])

Attachments

(4 files)

Priority: -- → P3
Whiteboard: [stockwell unknown]
Adding to my backlog.

Note to self: rewrite using modern async handling, especially BrowserTestUtils for opening a new tab & first load - looks like the load/open isn't being correctly listened to and hanging the test.
Assignee: nobody → standard8
Whiteboard: [stockwell unknown] → [stockwell unknown][fxsearch]
The patches modernise the tests and use some of the newer constructs for loading pages & waiting for the loads to complete. I'm hopeful that using these will resolve the intermittent failures here. I've pushed to try and will trigger some re-runs to hopefully work it out.

In any case, rewriting the tests to use the newer functions is probably a win for maintainability.
Comment on attachment 8895241 [details]
Bug 1314670 - Create a new search engine behaviors test to replace the old individual ones.

https://reviewboard.mozilla.org/r/166396/#review172214
Attachment #8895241 - Flags: review?(florian) → review+
Comment on attachment 8895242 [details]
Bug 1314670 - Rewrite the new search engine behaviors test to use async functionality.

https://reviewboard.mozilla.org/r/166398/#review172200

::: browser/components/search/test/browser_searchEngine_behaviors.js:123
(Diff revision 2)
>      },
>      {
>        name: "new tab search",
>        searchURL: base + "&t=ffnt",
> -      run() {
> -        function doSearch(doc) {
> +      async preTest(tab) {
> +        await BrowserTestUtils.loadURI(tab.linkedBrowser, "about:newtab");

nit: let browser = tab.linkedBrowser; to avoid duplicating tab.linkedBrowser 3 times.
Attachment #8895242 - Flags: review?(florian) → review+
Comment on attachment 8895243 [details]
Bug 1314670 - Merge the browser_*behavior.js tests into the new tests.

https://reviewboard.mozilla.org/r/166400/#review172216
Attachment #8895243 - Flags: review?(florian) → review+
Comment on attachment 8895244 [details]
Bug 1314670 - Update browser_google_behavior.js to use the same test structure as browser_searchEngineBehaviors.js.

https://reviewboard.mozilla.org/r/166402/#review172218
Attachment #8895244 - Flags: review?(florian) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/236bbdf4fc27
Create a new search engine behaviors test to replace the old individual ones. r=florian
https://hg.mozilla.org/integration/autoland/rev/5ad5569f62ae
Rewrite the new search engine behaviors test to use async functionality. r=florian
https://hg.mozilla.org/integration/autoland/rev/e301b87418a6
Merge the browser_*behavior.js tests into the new tests. r=florian
https://hg.mozilla.org/integration/autoland/rev/2defe6e0a993
Update browser_google_behavior.js to use the same test structure as browser_searchEngineBehaviors.js. r=florian
You need to log in before you can comment on or make changes to this bug.