Closed
Bug 1314670
Opened 8 years ago
Closed 7 years ago
Intermittent browser/components/search/test/browser_amazon_behavior.js | Test timed out -
Categories
(Firefox :: Search, defect, P3)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 57
People
(Reporter: intermittent-bug-filer, Assigned: standard8)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell unknown][fxsearch])
Attachments
(4 files)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=5472325&repo=mozilla-central https://archive.mozilla.org/pub/firefox/nightly/2016/11/2016-11-02-03-02-05-mozilla-central/mozilla-central_win8_64_test_pgo-mochitest-e10s-browser-chrome-1-bm112-tests1-windows-build10.txt.gz
Updated•7 years ago
|
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell unknown]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 8•7 years ago
|
||
Adding to my backlog. Note to self: rewrite using modern async handling, especially BrowserTestUtils for opening a new tab & first load - looks like the load/open isn't being correctly listened to and hanging the test.
Assignee: nobody → standard8
Whiteboard: [stockwell unknown] → [stockwell unknown][fxsearch]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 16•7 years ago
|
||
The patches modernise the tests and use some of the newer constructs for loading pages & waiting for the loads to complete. I'm hopeful that using these will resolve the intermittent failures here. I've pushed to try and will trigger some re-runs to hopefully work it out. In any case, rewriting the tests to use the newer functions is probably a win for maintainability.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8895241 [details] Bug 1314670 - Create a new search engine behaviors test to replace the old individual ones. https://reviewboard.mozilla.org/r/166396/#review172214
Attachment #8895241 -
Flags: review?(florian) → review+
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8895242 [details] Bug 1314670 - Rewrite the new search engine behaviors test to use async functionality. https://reviewboard.mozilla.org/r/166398/#review172200 ::: browser/components/search/test/browser_searchEngine_behaviors.js:123 (Diff revision 2) > }, > { > name: "new tab search", > searchURL: base + "&t=ffnt", > - run() { > - function doSearch(doc) { > + async preTest(tab) { > + await BrowserTestUtils.loadURI(tab.linkedBrowser, "about:newtab"); nit: let browser = tab.linkedBrowser; to avoid duplicating tab.linkedBrowser 3 times.
Attachment #8895242 -
Flags: review?(florian) → review+
Comment 22•7 years ago
|
||
mozreview-review |
Comment on attachment 8895243 [details] Bug 1314670 - Merge the browser_*behavior.js tests into the new tests. https://reviewboard.mozilla.org/r/166400/#review172216
Attachment #8895243 -
Flags: review?(florian) → review+
Comment 23•7 years ago
|
||
mozreview-review |
Comment on attachment 8895244 [details] Bug 1314670 - Update browser_google_behavior.js to use the same test structure as browser_searchEngineBehaviors.js. https://reviewboard.mozilla.org/r/166402/#review172218
Attachment #8895244 -
Flags: review?(florian) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 28•7 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/236bbdf4fc27 Create a new search engine behaviors test to replace the old individual ones. r=florian https://hg.mozilla.org/integration/autoland/rev/5ad5569f62ae Rewrite the new search engine behaviors test to use async functionality. r=florian https://hg.mozilla.org/integration/autoland/rev/e301b87418a6 Merge the browser_*behavior.js tests into the new tests. r=florian https://hg.mozilla.org/integration/autoland/rev/2defe6e0a993 Update browser_google_behavior.js to use the same test structure as browser_searchEngineBehaviors.js. r=florian
Comment 29•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/236bbdf4fc27 https://hg.mozilla.org/mozilla-central/rev/5ad5569f62ae https://hg.mozilla.org/mozilla-central/rev/e301b87418a6 https://hg.mozilla.org/mozilla-central/rev/2defe6e0a993
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 30•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/ab55f7d014e7 https://hg.mozilla.org/releases/mozilla-beta/rev/cb14f9a3b393 https://hg.mozilla.org/releases/mozilla-beta/rev/da1b102d7202 https://hg.mozilla.org/releases/mozilla-beta/rev/6493182684c4
status-firefox56:
--- → fixed
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•