1314693 - Addon and module correlations missing for Firefox 51 and 52

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[(No longer employed by Mozilla) Aaron Klotz]

https://crash-analysis.mozilla.com/crash_analysis/20161102/

There's nothing there for 51 or 52...

Comment 1

[Peter Bengtsson [:peterbe]]

I have no idea what's changed but I noticed this line in the error::

 /data/socorro/application/scripts/crons/cron_libraries.sh: line 73: ./active-firefox-versions.py: No such file or directory

The execution to get the list of `VERSIONS` happens here: https://github.com/mozilla/socorro/blob/master/scripts/crons/cron_libraries.sh#L73 and clearly this assumes that the cron bash execution happens in the same directory as https://github.com/mozilla/socorro/blob/master/scripts/crons/cron_libraries.sh

What I've done is to test to manually edit that line so that instead of::

 VERSIONS=`./active-firefox-versions.py`

It's now::

 VERSIONS=`/data/socorro/application/scripts/crons/active-firefox-versions.py`

That's pretty gross but nobody maintains this script anyway so it's worth a shot. 
I'm running it now. Let's see if it changes things.

Comment 2

[Peter Bengtsson [:peterbe]]

By the way Aaron,
This is the first time I've ever heard from somebody actually using the correlations since Lars left maintenance of it.

We are on a path to deprecate pulling these old correlation reports into the Crash-stats webapp. 

In fact, we're going to replace it with a totally different reporter built by Marco (CC'ed on bug). Have you looked into his tooling as an alternative?

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

I have, in fact my initial assumption as to why the data was missing is that it had been migrated to Marco's tools.

I don't see one for module correlations, though. I'm not sure if I missed that or if it doesn't exist yet.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Aaron Klotz [:aklotz] from comment #3)
> I don't see one for module correlations, though. I'm not sure if I missed
> that or if it doesn't exist yet.

It doesn't exist yet. I couldn't add modules because they weren't available through SuperSearch, but they will be available as soon as the data will be on Telemetry (bug 1311648 and dependencies).

Comment 5

[Peter Bengtsson [:peterbe]]

https://crash-analysis.mozilla.com/crash_analysis/20161102/ looks a lot fuller now. 
Seems my hack worked. I'll apply it.

Comment 6

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3578

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9dd5c4f2854b35ab1a5f22642ca2ce13a8954b16
fixes bug 1314693 - execute script to get right Firefox versions correctly (#3578)