1314712 - mozapkpublisher: Prevent single locale APKs from being uploaded

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

Let's prevent bug #1314063 from happening again! 

:flod told me where we can know if an APK is a multilocale one or not. It's in:
> $APK_PATH:assets/omni.ja:chrome/*

Both the APK and omni.ja are zip files. Chrome contains many folders: some unrelated to locales + 1 per locale. It also has a manifest at the root, explaining how locales are mapped.

I'll use that file to guess how many locales we have and raise errors accordingly.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: PR

Asking also for feedback from :flod, in order to know if the procedure is strong enough.

I tested the patch manually and it detected 76 languages on an aurora multi-locale, and just 1 on an en-US build. Automated tests will come along [1]


[1] https://github.com/mozilla-releng/mozapkpublisher/pull/3

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8806833 [details] [review]
PR

The approach makes absolutely sense. Tested and it works as expected.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Oops, that issue should have been closed a while ago. Landed on master on Nov 7th at:  https://github.com/mozilla-releng/mozapkpublisher/commit/a9eee6d804d23181687c2496c0f936db2d349820