Closed Bug 1314713 Opened 3 years ago Closed 3 years ago
buildsymbols race condition with symbols
59 bytes, text/x-review-board-request
I hit this error on a Windows try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e677f4aeb0ada16e6909a3a0d4512e3976bd699&selectedJob=30323644 10:25:25 INFO - adding: firefox-52.0a1-WINNT-20161102090639-x86-symbols.txt.tmp 10:25:25 INFO - zip warning: No such file or directory 10:25:25 INFO - zip warning: could not open for reading: firefox-52.0a1-WINNT-20161102090639-x86-symbols.txt.tmp The symbolsarchive target is creating the .tmp file, and so it's racing with the symbolsfullarchive target which is zipping everything in that directory: https://hg.mozilla.org/mozilla-central/annotate/3e73fd638e687a4d7f46613586e5156b8e2af846/Makefile.in#l335 We could just stop generating the symbols.txt files, or at least stop doing the grep here. We're not going to be using them for cleanup anymore, so they don't really serve any purpose.
Comment on attachment 8849280 [details] Bug 1314713 - Stop generating *symbols.txt files as part of dumping/packaging build symbols. https://reviewboard.mozilla.org/r/122096/#review125920 We can actually go a little further in a followup, symbolstore.py can stop printing the filenames as well. Can you file that? Not critical but might as well not print out stuff we don't need. ::: Makefile.in:310 (Diff revision 1) > symbolsarchive: generatesymbols > cd $(DIST)/crashreporter-symbols && \ > - grep 'sym' $(SYMBOL_INDEX_NAME) > $(SYMBOL_INDEX_NAME).tmp && \ > - mv $(SYMBOL_INDEX_NAME).tmp $(SYMBOL_INDEX_NAME) > - cd $(DIST)/crashreporter-symbols && \ > zip -r5D '../$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip' . -i '*.sym' -i '*.txt' You can ditch the `-i '*.txt'` bit here now.
Attachment #8849280 - Flags: review?(ted) → review+
Comment on attachment 8849280 [details] Bug 1314713 - Stop generating *symbols.txt files as part of dumping/packaging build symbols. https://reviewboard.mozilla.org/r/122096/#review125920 I think I'm going to find this useful in bug 1337986 , let's see how that pans out.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/43dfa7e2fb45 Stop generating *symbols.txt files as part of dumping/packaging build symbols. r=ted
You need to log in before you can comment on or make changes to this bug.