TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_private_browsing_window.js | New Window's label should be overwritten - Got New Window, expected New Private Window

RESOLVED FIXED

Status

L20n
JS Library
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Pike, Assigned: gandalf)

Tracking

(Blocks: 1 bug)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
We have a test failure on bc7 about private browsing.

TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_private_browsing_window.js | New Window's label should be overwritten - Got New Window, expected New Private Window

The test failure reproduces if run individually.
(Assignee)

Comment 1

a year ago
I'll give it a try.
Assignee: nobody → gandalf
(Reporter)

Comment 2

a year ago
This is actually a bug, https://hg.mozilla.org/projects/larch/file/default/browser/base/content/browser.js#l7531 - 7557 need fixes. Probably changing data-l10n-id instead of label?
Comment hidden (mozreview-request)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8807389 [details]
Bug 1314749 - Copy l10nId, not label and accesskey between elements.

https://reviewboard.mozilla.org/r/90536/#review90318

We'll need to do similar things as this when we convert more of browser.xul, notably the document.title attribute.

r=me.
Attachment #8807389 - Flags: review?(l10n) → review+
(Reporter)

Comment 5

a year ago
Pushed this to larch so that we get a cleaner picture for the menupopup-cries-for-help.

https://hg.mozilla.org/projects/larch/rev/fbf61bcc0fa52b238d0a88e567a189d00b407613

Marking FIXED.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.