1314829 - Remove no-unused-expressions from the recommended configuration

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Dave Townsend [:mossop]]

I started trying to turn this rule on and what I found roughly in order of quantity of things it caught:

* Statements that did actually have side-effects and had to have the rule disabled because they deal with XPCOM getters, e.g. node.clientTop forcing XBL to apply, etc.
* Statements that people had accidentally or intentionally ended with a "," instead of a ";". Those didn't constitute bugs.
* Cases where "use strict" was used in the middle of a function or file.

Only the latter is a behaviour changing bug so I don't think it is worth considering enabling this rule to support just that case when there are many cases where it just has to be disabled.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1314829: Remove no-unused-expressions from the recommended configuration.

Review commit: https://reviewboard.mozilla.org/r/90440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90440/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8807201 [details]
Bug 1314829: Remove no-unused-expressions from the recommended configuration.

https://reviewboard.mozilla.org/r/90440/#review90130

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43aec132d58e
Remove no-unused-expressions from the recommended configuration. r=jaws DONTBUILD

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/43aec132d58e