Closed Bug 1314829 Opened 3 years ago Closed 3 years ago

Remove no-unused-expressions from the recommended configuration

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file)

I started trying to turn this rule on and what I found roughly in order of quantity of things it caught:

* Statements that did actually have side-effects and had to have the rule disabled because they deal with XPCOM getters, e.g. node.clientTop forcing XBL to apply, etc.
* Statements that people had accidentally or intentionally ended with a "," instead of a ";". Those didn't constitute bugs.
* Cases where "use strict" was used in the middle of a function or file.

Only the latter is a behaviour changing bug so I don't think it is worth considering enabling this rule to support just that case when there are many cases where it just has to be disabled.
Assignee: nobody → dtownsend
Comment on attachment 8807201 [details]
Bug 1314829: Remove no-unused-expressions from the recommended configuration.

https://reviewboard.mozilla.org/r/90440/#review90130
Attachment #8807201 - Flags: review?(jaws) → review+
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43aec132d58e
Remove no-unused-expressions from the recommended configuration. r=jaws DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/43aec132d58e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.