1314847 - Sign mar files as part of signingscriptworker

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Justin Wood (:Callek)]

We need to invoke mar signing as part of taskcluster, and probably beetmove these somehow

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir

Review commit: https://reviewboard.mozilla.org/r/90216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90216/

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8806978 [details]
Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir

This is explicitly a WIP, and doesn't block our target of "beetmove first" but probably blocks updates entirely.

This patch is touching only l10n, but mainly because I ran out of time tonight to touch anything else...

Comment 3

[Kim Moir [:kmoir] ET]

Comment on attachment 8806978 [details]
Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir

https://reviewboard.mozilla.org/r/90216/#review90106

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8806978 [details]
Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir

https://reviewboard.mozilla.org/r/90216/#review90120

This is OK to land as-is, but hopefully a useful change suggested below that would only take a few minutes to put together.

::: taskcluster/taskgraph/transforms/nightly_l10n_signing.py:26
(Diff revision 1)
> +            extensions = ['.apk']
> +            signing_formats = ["jar"]
> +        else:
> +            extensions = ['.tar.bz2', '.complete.mar']
> +            signing_formats = ["gpg", "mar"]

It's not clear from reading that these lists are zipped.  Could you switch it around to something like 

      job_specs = [
        {
          'extensions': ['.apk'],
          'format': 'jar',
        },
      ]
    else:
      job_specs = [
        {
          'extensions': ['.tar.bz2', '.checksums'],
          'format': 'gpg',
        }, {
          'extensions': ['.complete.mar'],
          'format': 'mar',
        }
        
This would have the benefit of removing the `.tar.bz2` special-case below.

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8806978 [details]
Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90216/diff/1-2/

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8806978 [details]
Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir

This is a landing-ready (I think) patch.  Thanks!

Comment 7

[Kim Moir [:kmoir] ET]

Comment on attachment 8806978 [details]
Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir

https://reviewboard.mozilla.org/r/90216/#review90812

Comment 8

[Justin Wood (:Callek)]

This landed on date, but looks like we're going to go with Bug 1316214 as our fate.