Intermittent toolkit/components/thumbnails/test/browser_thumbnails_bg_bad_url.js | Test timed out -

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

Tracking

({intermittent-failure})

unspecified
mozilla54
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(1 attachment)

Comment hidden (Intermittent Failures Robot)
Lots of recent failures here (almost exclusively linux64-asan, e10s), apparently triggered by bug 1338215.
Blocks: 1338215
Flags: needinfo?(gijskruitbosch+bugs)
Comment hidden (Intermittent Failures Robot)
(Assignee)

Comment 4

2 years ago
It's hard to know what is going on here because there's no information in the logs. However, especially because this is ASAN, I suspect the problem is that the listener QIs to a weak reference, and in an ASAN build that means it disappears before the file is loaded, meaning it never fires and moves the code on.

If I'm right, the obvious fix is to keep a strong ref to the listener. :-)

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ed3bb75f83f14aae73d0cc26af10351b5bb9af
Comment hidden (mozreview-request)
(Assignee)

Comment 6

2 years ago
The trypush looks convincing here. Sorry for the mess-up, Mark. :-(
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [stockwell needswork]

Comment 7

2 years ago
mozreview-review
Comment on attachment 8842901 [details]
Bug 1314855 - keep a strong reference to the listener for background thumbnail pages,

https://reviewboard.mozilla.org/r/116646/#review118500

sounds legit!
Attachment #8842901 - Flags: review?(markh) → review+
Comment hidden (Intermittent Failures Robot)

Comment 9

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/06464864d84f
keep a strong reference to the listener for background thumbnail pages, r=markh
Comment hidden (Intermittent Failures Robot)

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/06464864d84f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Whiteboard: [stockwell needswork] → [stockwell fixed]
status-firefox52: --- → wontfix
status-firefox53: --- → affected
status-firefox-esr52: --- → affected
status-firefox52: wontfix → unaffected
status-firefox53: affected → unaffected
status-firefox-esr52: affected → unaffected
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.