1314855 - Intermittent toolkit/components/thumbnails/test/browser_thumbnails_bg_bad_url.js | Test timed out -

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=38584260&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/H73cBGOSTie9I0Dz5xJJlQ/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Intermittent Failures Robot]

16 failures in 87 pushes (0.184 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* autoland: 14
* mozilla-central: 2

Platform breakdown:
* linux64: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314855&startday=2017-02-28&endday=2017-02-28&tree=all

Comment 2

[Geoff Brown [:gbrown]]

Lots of recent failures here (almost exclusively linux64-asan, e10s), apparently triggered by bug 1338215.

Comment 3

[Intermittent Failures Robot]

38 failures in 181 pushes (0.21 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* autoland: 18
* mozilla-inbound: 13
* try: 5
* mozilla-central: 1
* graphics: 1

Platform breakdown:
* linux64: 38

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314855&startday=2017-03-01&endday=2017-03-01&tree=all

Comment 4

[:Gijs (he/him)]

It's hard to know what is going on here because there's no information in the logs. However, especially because this is ASAN, I suspect the problem is that the listener QIs to a weak reference, and in an ASAN build that means it disappears before the file is loaded, meaning it never fires and moves the code on.

If I'm right, the obvious fix is to keep a strong ref to the listener. :-)

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ed3bb75f83f14aae73d0cc26af10351b5bb9af

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1314855 - keep a strong reference to the listener for background thumbnail pages,

Review commit: https://reviewboard.mozilla.org/r/116646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116646/

Comment 6

[:Gijs (he/him)]

The trypush looks convincing here. Sorry for the mess-up, Mark. :-(

Comment 7

[Mark Hammond [:markh] [:mhammond] - PTO until April 20]

Comment on attachment 8842901 [details]
Bug 1314855 - keep a strong reference to the listener for background thumbnail pages,

https://reviewboard.mozilla.org/r/116646/#review118500

sounds legit!

Comment 8

[Intermittent Failures Robot]

50 failures in 149 pushes (0.336 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* mozilla-inbound: 28
* autoland: 14
* mozilla-central: 4
* try: 2
* oak: 1
* graphics: 1

Platform breakdown:
* linux64: 37
* osx-10-7: 3
* windows2012-64: 2
* windows2012-32: 2
* linux32: 2
* windowsxp: 1
* windows8-64: 1
* linux64-stylo: 1
* android-4-0-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314855&startday=2017-03-02&endday=2017-03-02&tree=all

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06464864d84f
keep a strong reference to the listener for background thumbnail pages, r=markh

Comment 10

[Intermittent Failures Robot]

38 failures in 157 pushes (0.242 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* autoland: 22
* mozilla-inbound: 12
* mozilla-central: 2
* try: 1
* graphics: 1

Platform breakdown:
* linux64: 35
* linux32: 2
* android-4-3-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314855&startday=2017-03-03&endday=2017-03-03&tree=all

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06464864d84f

Comment 12

[Intermittent Failures Robot]

154 failures in 783 pushes (0.197 failures/push) were associated with this bug in the last 7 days. 

This is the #4 most frequent failure this week. 

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:
* autoland: 73
* mozilla-inbound: 57
* mozilla-central: 10
* try: 9
* graphics: 3
* oak: 2

Platform breakdown:
* linux64: 138
* linux32: 4
* osx-10-7: 3
* windows2012-64: 2
* windows2012-32: 2
* windowsxp: 1
* windows8-64: 1
* linux64-stylo: 1
* android-4-3-armv7-api15: 1
* android-4-0-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314855&startday=2017-02-27&endday=2017-03-05&tree=all

Comment 13

[Intermittent Failures Robot]

1 failures in 949 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314855&startday=2017-08-14&endday=2017-08-20&tree=all