Closed Bug 1314855 Opened 3 years ago Closed 3 years ago

Intermittent toolkit/components/thumbnails/test/browser_thumbnails_bg_bad_url.js | Test timed out -

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

Lots of recent failures here (almost exclusively linux64-asan, e10s), apparently triggered by bug 1338215.
Blocks: 1338215
Flags: needinfo?(gijskruitbosch+bugs)
It's hard to know what is going on here because there's no information in the logs. However, especially because this is ASAN, I suspect the problem is that the listener QIs to a weak reference, and in an ASAN build that means it disappears before the file is loaded, meaning it never fires and moves the code on.

If I'm right, the obvious fix is to keep a strong ref to the listener. :-)

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ed3bb75f83f14aae73d0cc26af10351b5bb9af
The trypush looks convincing here. Sorry for the mess-up, Mark. :-(
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [stockwell needswork]
Comment on attachment 8842901 [details]
Bug 1314855 - keep a strong reference to the listener for background thumbnail pages,

https://reviewboard.mozilla.org/r/116646/#review118500

sounds legit!
Attachment #8842901 - Flags: review?(markh) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/06464864d84f
keep a strong reference to the listener for background thumbnail pages, r=markh
https://hg.mozilla.org/mozilla-central/rev/06464864d84f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Whiteboard: [stockwell needswork] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.