Closed Bug 1314884 Opened 3 years ago Closed 3 years ago

Remove SeekTarget::mEventVisibility

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(7 files)

58 bytes, text/x-review-board-request
kaku
: review+
Details
58 bytes, text/x-review-board-request
kaku
: review+
Details
58 bytes, text/x-review-board-request
kaku
: review+
Details
58 bytes, text/x-review-board-request
kaku
: review+
Details
58 bytes, text/x-review-board-request
kaku
: review+
Details
58 bytes, text/x-review-board-request
kaku
: review+
Details
58 bytes, text/x-review-board-request
kaku
: review+
Details
This member is used by SeekingState::Enter() only. We can pass an additional parameter to SeekingState::Enter() to indicate whether to publish events during seeking.
Assignee: nobody → jwwang
Blocks: 1286129
Priority: -- → P3
Attachment #8808457 - Flags: review?(kaku)
Attachment #8808458 - Flags: review?(kaku)
Attachment #8808459 - Flags: review?(kaku)
Attachment #8808460 - Flags: review?(kaku)
Attachment #8808461 - Flags: review?(kaku)
Attachment #8808462 - Flags: review?(kaku)
Attachment #8808463 - Flags: review?(kaku)
Comment on attachment 8808457 [details]
Bug 1314884. Part 1 - move the calculation of seek target into DormantState::Enter() so we don't need to pass a SeekJob to the function.

https://reviewboard.mozilla.org/r/91278/#review91498
Attachment #8808457 - Flags: review?(kaku) → review+
Comment on attachment 8808458 [details]
Bug 1314884. Part 2 - Let DORMANT transition to SEEKING when play state changes to PLAYING since we need to seek anyway whenever exiting dormant.

https://reviewboard.mozilla.org/r/91280/#review91500
Attachment #8808458 - Flags: review?(kaku) → review+
Comment on attachment 8808459 [details]
Bug 1314884. Part 3 - remove the call to |mPendingSeek.RejectIfExists(__func__)| from DormantState::HandleSeek() since it will be rejected in Exit() before transitioning to SEEKING.

https://reviewboard.mozilla.org/r/91282/#review91502
Attachment #8808459 - Flags: review?(kaku) → review+
Comment on attachment 8808460 [details]
Bug 1314884. Part 4 - extract the code of HandleSeek() to the parent class.

https://reviewboard.mozilla.org/r/91284/#review91504
Attachment #8808460 - Flags: review?(kaku) → review+
Comment on attachment 8808461 [details]
Bug 1314884. Part 5 - pass StateObject::EventVisibility to SeekingState::Enter() to indicate whether to publish events during seek.

https://reviewboard.mozilla.org/r/91286/#review91506
Attachment #8808461 - Flags: review?(kaku) → review+
Comment on attachment 8808462 [details]
Bug 1314884. Part 6 - remove SeekTarget::mEventVisibility.

https://reviewboard.mozilla.org/r/91288/#review91508
Attachment #8808462 - Flags: review?(kaku) → review+
Comment on attachment 8808463 [details]
Bug 1314884. Part 7 - remove SeekResolveValue::mEventVisibility for we always assume MediaDecoderEventVisibility::Observable in P6.

https://reviewboard.mozilla.org/r/91290/#review91510
Attachment #8808463 - Flags: review?(kaku) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/268128dac277
Part 1 - move the calculation of seek target into DormantState::Enter() so we don't need to pass a SeekJob to the function. r=kaku
https://hg.mozilla.org/integration/autoland/rev/3bcc70c0259f
Part 2 - Let DORMANT transition to SEEKING when play state changes to PLAYING since we need to seek anyway whenever exiting dormant. r=kaku
https://hg.mozilla.org/integration/autoland/rev/32223527f7f8
Part 3 - remove the call to |mPendingSeek.RejectIfExists(__func__)| from DormantState::HandleSeek() since it will be rejected in Exit() before transitioning to SEEKING. r=kaku
https://hg.mozilla.org/integration/autoland/rev/f443222a39c8
Part 4 - extract the code of HandleSeek() to the parent class. r=kaku
https://hg.mozilla.org/integration/autoland/rev/c2d1763308e6
Part 5 - pass StateObject::EventVisibility to SeekingState::Enter() to indicate whether to publish events during seek. r=kaku
https://hg.mozilla.org/integration/autoland/rev/392e20da0963
Part 6 - remove SeekTarget::mEventVisibility. r=kaku
https://hg.mozilla.org/integration/autoland/rev/3a67958e318a
Part 7 - remove SeekResolveValue::mEventVisibility for we always assume MediaDecoderEventVisibility::Observable in P6. r=kaku
You need to log in before you can comment on or make changes to this bug.