Closed Bug 1314900 Opened 3 years ago Closed 3 years ago

Dump MIR expressions

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: h4writer, Assigned: h4writer)

Details

Attachments

(1 file)

I added a convenient way to create a list of MIR expressions. It makes it easier to see which GVN we forgot. I did this as a side-patch, but I see no reason why not get it in the tree for other to replicate?
Attached patch PatchSplinter Review
Assignee: nobody → hv1989
Attachment #8807088 - Flags: review?(jdemooij)
Comment on attachment 8807088 [details] [diff] [review]
Patch

Review of attachment 8807088 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/JitSpewer.h
@@ +63,5 @@
>      /* Information of tracked opt strats */ \
>      _(OptimizationTracking)                 \
>      /* Debug info about the I$ */           \
>      _(CacheFlush)                           \
> +    /* Debug info about the I$ */           \

nit: bad copy/pasto
Priority: -- → P3
Comment on attachment 8807088 [details] [diff] [review]
Patch

Review of attachment 8807088 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

::: js/src/jit/IonAnalysis.cpp
@@ +4666,5 @@
> +
> +static void
> +DumpDefinition(GenericPrinter& out, MDefinition* def, size_t depth)
> +{
> +    def->PrintOpcodeName(out, def->op());

Nit: s/def->/MDefinition::/

::: js/src/jit/JitSpewer.h
@@ +63,5 @@
>      /* Information of tracked opt strats */ \
>      _(OptimizationTracking)                 \
>      /* Debug info about the I$ */           \
>      _(CacheFlush)                           \
> +    /* Debug info about the I$ */           \

See Benjamin's comment.
Attachment #8807088 - Flags: review?(jdemooij) → review+
Pushed by hv1989@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d23f30439519
IonMonkey - Add flag to IONFLAGS to spew the MIR expressions, r=jandem
https://hg.mozilla.org/mozilla-central/rev/d23f30439519
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.