1314981 - Remove clean working directory sanity check

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

4d50a677b989 (bug 1292071) introduced a temporary sanity check that the working directory was clean. AFAIK the check has never reported an error. It adds ~5s overhead to run-task, so let's kill it.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1314981 - Remove clean working directory check;

As the inline comment says, this was meant to be temporary. The check
has never fired AFAIK. The check adds ~5s overhead to run-task when
there is a source checkout. So let's remove it and get our time back.

Review commit: https://reviewboard.mozilla.org/r/90436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90436/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8807173 [details]
Bug 1314981 - Remove clean working directory check;

https://reviewboard.mozilla.org/r/90436/#review90134

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b39b2ddf6ab9
Remove clean working directory check; r=dustin

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b39b2ddf6ab9