Closed Bug 1314997 Opened 8 years ago Closed 7 years ago

Reduce code duplication in addon-related Scala dataset generation code

Categories

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mreid, Assigned: wlach)

References

Details

Attachments

(1 file)

56 bytes, text/x-github-pull-request
Details | Review
There are several different, but almost identical variations on an Addon case class in the telemetry-batch-view code. We should reduce this repetitive code. One is used in the cross-sectional code, one used by MainSummary for parsing addons from incoming JSON, and another in AddonsViewTest for generating test addon data.
Blocks: 1255755
There's one in AddonRecommender too :)
Points: --- → 3
Priority: -- → P3
Going to take a stab at this one.
Assignee: nobody → wlachance
Attached file PR
As discussed on IRC, we probably need two representations of an "addon" for ease of serialization/deserialization. One corresponding to the json format in a telemetry ping (using camel case fields), another corresponding to the parquet format (using a more limited set of snake case fields) This PR attempts to implement that.
Closing abandoned bugs in this product per https://bugzilla.mozilla.org/show_bug.cgi?id=1337972
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Product: Cloud Services → Cloud Services Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: