1315004 - rename Range::start to Range::begin to match C++ conventions

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Nathan Froyd [:froydnj]]

Among other things, this change means that you can use ranged-for syntax
with Range, which is more fitting and pleasant than the alternative.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: rename Range::start to Range::begin to match C++ conventions

It's possible this will require a bit of fixup; my tree might not be entirely
up-to-date.  I checked bug 811060, which added Range, for clues as to the
naming of |start|, but there wasn't any special reason for it, so I think it's
just as well to change it to |begin|.

Comment 2

[Jeff Walden [:Waldo]]

Just that "start" as noun makes a lot more sense in spoken/written English for describing the beginning of a range.  You don't talk about the "begin" of a range, you talk about the start of a range.  And range isn't an action, so "begin" as verb doesn't make sense, either.

Still, given the C++ convention, un-English tho it may be, we should switch.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Just that "start" as noun makes a lot more sense in spoken/written English
> for describing the beginning of a range.  You don't talk about the "begin"
> of a range, you talk about the start of a range.  And range isn't an action,
> so "begin" as verb doesn't make sense, either.

This is quite true.  Then again, the "begin" of a vector (map, etc.) doesn't make sense in English either, and same for the verb case.  Welcome to C++. =/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7088aa43bf5
rename Range::start to Range::begin to match C++ conventions; r=botond

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d7088aa43bf5