Closed Bug 1315004 Opened 4 years ago Closed 4 years ago

rename Range::start to Range::begin to match C++ conventions

Categories

(Core :: MFBT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

Among other things, this change means that you can use ranged-for syntax
with Range, which is more fitting and pleasant than the alternative.
It's possible this will require a bit of fixup; my tree might not be entirely
up-to-date.  I checked bug 811060, which added Range, for clues as to the
naming of |start|, but there wasn't any special reason for it, so I think it's
just as well to change it to |begin|.
Attachment #8807208 - Flags: review?(botond)
Just that "start" as noun makes a lot more sense in spoken/written English for describing the beginning of a range.  You don't talk about the "begin" of a range, you talk about the start of a range.  And range isn't an action, so "begin" as verb doesn't make sense, either.

Still, given the C++ convention, un-English tho it may be, we should switch.
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Just that "start" as noun makes a lot more sense in spoken/written English
> for describing the beginning of a range.  You don't talk about the "begin"
> of a range, you talk about the start of a range.  And range isn't an action,
> so "begin" as verb doesn't make sense, either.

This is quite true.  Then again, the "begin" of a vector (map, etc.) doesn't make sense in English either, and same for the verb case.  Welcome to C++. =/
Attachment #8807208 - Flags: review?(botond) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7088aa43bf5
rename Range::start to Range::begin to match C++ conventions; r=botond
https://hg.mozilla.org/mozilla-central/rev/d7088aa43bf5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.