Open Bug 1315049 Opened 8 years ago Updated 1 year ago

Don't use %p in cycle collector graph logging

Categories

(Core :: Cycle Collector, task, P3)

task

Tracking

()

People

(Reporter: mccr8, Unassigned)

Details

%p prints out things differently on Windows, compared to other platforms. It is used in the CC logger to print out addresses. This makes writing a parser for logs annoying. I think that using PRIxPTR instead will be more cross-platform. I should also fix up GC logging at the same time, or in a separate bug.
Here's a bit of what the new output looks like:

7f83bd44a060 [gc] JS Object (BackstagePass)
> 7f83bd442520 group_proto
> 7f83bd44a060 group_global
Did you want to finish this up?  Or did we already do this in a separate bug?
Flags: needinfo?(continuation)
Priority: -- → P3
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Did you want to finish this up?  Or did we already do this in a separate bug?

Yeah this should still get done at some point. I think when I looked at it last I got pulled into some sort of yak shaving involving the log processor. Maybe I can look at it soon.
Realistically I'm not going to be able to get to this soon. But it would still be good...
Assignee: continuation → nobody
Flags: needinfo?(continuation)
Severity: normal → N/A
Type: defect → task
Component: XPCOM → Cycle Collector
You need to log in before you can comment on or make changes to this bug.