Closed
Bug 1315109
Opened 8 years ago
Closed 5 years ago
[Signature report] Hide correlations tab for non-supported products
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adrian, Assigned: willkg)
References
Details
Attachments
(1 file)
With the new correlations system (bug 1306891), when a user is filtering on a non-supported product, for example Thunderbird, then the Correlations tab is shown and defaults to Firefox correlations. To me that doesn't make sense. I think we should simply hide the correlations tab if none of the supported products are in the product parameter.
Comment 1•8 years ago
|
||
We used to have code that decides to show or hide the Correlations tab based on an AJAX lookup. Will, now, all Firefox crashes have a correlations?
Comment 2•8 years ago
|
||
(In reply to Peter Bengtsson [:peterbe] from comment #1) > We used to have code that decides to show or hide the Correlations tab based > on an AJAX lookup. > Will, now, all Firefox crashes have a correlations? The code to do that was (and is) only in the report page, but not in the signature page. In the report page it's easy, because you have a specific product, channel, version.
Assignee | ||
Comment 3•5 years ago
|
||
What I'm gathering from this is that if the product filter is set and it's not a product that is supported by correlations, we should not show the correlations tab. I think that's doable, but I'm going to simplify it and just have the tab say "This product isn't supported by correlations." I think that's simpler to implement and easier to test.
Assignee | ||
Comment 4•5 years ago
|
||
Assignee: nobody → willkg
Assignee | ||
Comment 5•5 years ago
|
||
Turns out it was simpler to not show the tab at all, so I did that. It's not too hard to test.
In doing that, I also moved the list of supported products into the view code so it's easier to adjust later.
Assignee | ||
Comment 6•5 years ago
|
||
Landed in https://github.com/mozilla-services/socorro/commit/7837c91aab0e30fcc74922ba5037fa65d3579ebb
Marking as FIXED.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•