1315134 - Search suggestions in awesomebar are not aligned correctly if browser.urlbar.maxRichResults > 10

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P3)

Description

[Bruce]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161102004003

Steps to reproduce:

General:
1) Set `browser.urlbar.maxRichResults` to be >10
2) Type something in the awesomebar on a tab without the forward button and get the results dropdown to show up.
3) Now switch to a tab with the forward button displayed and make the dropdown show up again.

More specific:
1) Set `browser.urlbar.maxRichResults` to be 15.
2) Create a new tab Tab1 (wouldn't have the forward button). Type something, observe that all the results in the dropdown are nicely aligned. Press enter at the 1st suggestion (say 'search with Google'). From the Google search results page, open any link then press the back button to return to the search results page. Tab1 now has a forward button.
3) Create another new tab Tab2 (wouldn't have the forward button, again). Type something and let the search suggestions drop down show up. Everything would still be nicely aligned. Close this tab to switch to Tab1.
4) Search for something in Tab1 and scroll down to below the 10th entry.

Here is a video of me doing the above steps on FF 51.0a2 (2016-11-02) (64-bit), Windows 10, recorded after having started the browser with add-ons disabled -> https://vid.me/uNcA .

*Reproducing this might require having bookmarks that match the queries you type in steps 2, 3 and 4.


Actual results:

Some of the results beyond the 10th suggestion are aligned for the presence of a forward button while others are aligned for its absence.


Expected results:

They should all be aligned correctly, as per this comment -> https://bugzilla.mozilla.org/show_bug.cgi?id=959564#c3.

Comment 1

[Bruce]

I should add that the latest stable, v49.0.2, doesn't have this issue.

Comment 2

[Bruce]

Can't reproduce on v58.0a1 (2017-10-12); closing.