Closed Bug 1315206 Opened 3 years ago Closed 3 years ago

Move more code from BrowserApp to BrowserAppDelegate implementations

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

Details

Attachments

(3 files)

BrowserApp is still pretty large and there's more code we can move to BrowserAppDelegate implementations. Basically everything that doesn't really depend on BrowserApp and just wants to hook into some lifecycle events.
Comment on attachment 8807492 [details]
Bug 1315206 - BrowserApp: Remove unneeded cast of BrowserAppDelegate objects.

https://reviewboard.mozilla.org/r/90638/#review90602
Attachment #8807492 - Flags: review?(max) → review+
Comment on attachment 8807490 [details]
Bug 1315206 - Move getIsInAutomationFromEnvironment from BrowserApp to IntentUtils.

https://reviewboard.mozilla.org/r/90632/#review90672
Comment on attachment 8807491 [details]
Bug 1315206 - Move Adjust related code from BrowserApp to delegate implementation.

https://reviewboard.mozilla.org/r/90636/#review90674

Nice and clean extraction!
Attachment #8807491 - Flags: review?(cnevinchen) → review+
Comment on attachment 8807490 [details]
Bug 1315206 - Move getIsInAutomationFromEnvironment from BrowserApp to IntentUtils.

https://reviewboard.mozilla.org/r/90634/#review90684
Attachment #8807490 - Flags: review?(walkingice0204) → review+
Comment on attachment 8807490 [details]
Bug 1315206 - Move getIsInAutomationFromEnvironment from BrowserApp to IntentUtils.

https://reviewboard.mozilla.org/r/90634/#review90762
Attachment #8807490 - Flags: review?(ahunt) → review+
Comment on attachment 8807491 [details]
Bug 1315206 - Move Adjust related code from BrowserApp to delegate implementation.

https://reviewboard.mozilla.org/r/90636/#review90764
Attachment #8807491 - Flags: review?(ahunt) → review+
Comment on attachment 8807492 [details]
Bug 1315206 - BrowserApp: Remove unneeded cast of BrowserAppDelegate objects.

https://reviewboard.mozilla.org/r/90638/#review90766
Attachment #8807492 - Flags: review?(ahunt) → review+
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d096235a4e02
Move getIsInAutomationFromEnvironment from BrowserApp to IntentUtils. r=ahunt,walkingice
https://hg.mozilla.org/integration/autoland/rev/e2daa72f9699
Move Adjust related code from BrowserApp to delegate implementation. r=ahunt,nechen
https://hg.mozilla.org/integration/autoland/rev/d25f3fd704e0
BrowserApp: Remove unneeded cast of BrowserAppDelegate objects. r=ahunt,maliu
https://hg.mozilla.org/mozilla-central/rev/d096235a4e02
https://hg.mozilla.org/mozilla-central/rev/e2daa72f9699
https://hg.mozilla.org/mozilla-central/rev/d25f3fd704e0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.