Crash in Client:@ASHorizontalScrollCellManager.collectionView(UICollectionView, cellForItemAtIndexPath : NSIndexPath) -> UICollectionViewCell (ActivityStreamTopSitesCell.swift:445)

VERIFIED FIXED

Status

()

Firefox for iOS
Home screen
P1
critical
VERIFIED FIXED
a year ago
10 months ago

People

(Reporter: csuciu, Assigned: sleroux)

Tracking

({crash, reproducible})

unspecified
Other
iOS 10
crash, reproducible

Firefox Tracking Flags

(fxios7.0+, fxios-v7.0 fixed)

Details

(Whiteboard: [MobileAS])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review | Splinter Review
(Reporter)

Description

a year ago
iPhone 7Plus/6S iOS 10
master b8b2deedd

1. Launch Firefox
2. Add 7 items in Top Sites
3. In portrait, delete the 7'th item
4. Rotate to landscape and delete the 6'th item

Result: Firefox crashes
Was this introduced via bug 1243412? Let's track this.
Flags: needinfo?(fpatel)
(Assignee)

Updated

a year ago
tracking-fxios: ? → 7.0+
Priority: -- → P2
Whiteboard: [MobileAS]
(Assignee)

Updated

a year ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Iteration: --- → 1.8
Component: General → Home screen
Priority: P2 → P1
(Assignee)

Comment 2

a year ago
Created attachment 8809519 [details] [review]
Github PR
Attachment #8809519 - Flags: review?(fpatel)
Comment on attachment 8809519 [details] [review]
Github PR

I've left some feedback of a case I think you missed. Please let me know if this is an issue.
Flags: needinfo?(fpatel)
Attachment #8809519 - Flags: review?(fpatel) → review+
Iteration: 1.8 → 1.9
(Assignee)

Comment 4

a year ago
master https://github.com/mozilla-mobile/firefox-ios/commit/94eeb3e98409962cdb17153a40578ebe92525752
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-fxios-v7.0: affected → fixed
Resolution: --- → FIXED

Comment 5

10 months ago
Verifying as fix on master d66101cc.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.